add exception if we try to get chainId from a tx wo chainId (v = 27 o… #1210
Conversation
…r 28) Signed-off-by: Francois Bojarski <[email protected]>
Signed-off-by: Francois Bojarski <[email protected]>
Signed-off-by: Francois Bojarski <[email protected]>
arithmetization/src/main/java/net/consensys/linea/zktracer/module/blockdata/Blockdata.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/blockdata/Blockdata.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Francois Bojarski <[email protected]>
| @@ -593,7 +593,7 @@ private void handlePhaseBeta(RlpTxnColumnsValue traceValue, Transaction tx, Trac | |||
| checkArgument(bigIntegerToBytes(V).size() <= 8, "V is longer than 8 bytes"); | |||
| final boolean betaIsZero = | |||
| V.equals(BigInteger.valueOf(27)) | |||
| || V.equals(BigInteger.valueOf(28)); // beta = ChainId = 0 iff (V == 27 or V == 28) | |||
| || V.equals(BigInteger.valueOf(28)); // beta = 0 iff (V == 27 or V == 28) | |||
There was a problem hiding this comment.
My understanding is that if v
There was a problem hiding this comment.
These transactions don't have replay protection and so can be replayed on any chain (that allows for such transactions.)
There was a problem hiding this comment.
we have a beta, but then beta is NOT the value of the chainId ...
| final long V = tx.getV().longValueExact(); | ||
| if (V == 27 || V == 28) { | ||
| return 0; | ||
| throw new IllegalArgumentException("ChainId not specified in transaction"); |
There was a problem hiding this comment.
What is the purpose of throwing an exception ? To print a message ? I see that we catch it and resume execution.
There was a problem hiding this comment.
If there is any exception that would be problematic it's if some transaction defines a chainId which does not coincide with that of Linea mainnet / testnet.
There was a problem hiding this comment.
we call this functiun in phaseBeta of RLP_TXN and here we'll be happy to catch exception if needed
There was a problem hiding this comment.
it's if some transaction defines a chainId which does not coincide with that of Linea mainnet / testnet.
Those transactions are supposed to be blocked by the sequencer.
| final long V = tx.getV().longValueExact(); | ||
| if (V == 27 || V == 28) { | ||
| return 0; | ||
| throw new IllegalArgumentException("ChainId not specified in transaction"); |
There was a problem hiding this comment.
If there is any exception that would be problematic it's if some transaction defines a chainId which does not coincide with that of Linea mainnet / testnet.
Signed-off-by: Francois Bojarski <[email protected]>
Signed-off-by: Francois Bojarski <[email protected]>
letypequividelespoubelles
deleted the
1209-get-the-chainid-for-blockdata
branch
Search for the chainId of the network in all tx of the conflation (instead of previously just the last tx). Will fail if all tx are wo chainId (will be fixed by hyperledger/besu#7630).
Add exception when trying to retrieve chainId of an unprotected tx (v == 27 or 28)