feat(req-limit): implement request limiting for trace generation and line counting #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerslider
force-pushed
the
feat/issue-1240/req-limiting
branch
from
667dd93
to
da51afe
Compare
FlorianHuc
reviewed
Sep 19, 2024
| public R execute(T request, Function<T, R> processingFunc) { | ||
| if (!semaphore.tryAcquire()) { | ||
| throw new PluginRpcEndpointException( | ||
| RpcErrorType.INVALID_REQUEST, |
There was a problem hiding this comment.
I believe we should use another error type, the request is valid, it's just the server which is busy
There was a problem hiding this comment.
I could not find a better error code, so I am open to suggestions.
| this.semaphore = new Semaphore(concurrentRequestsCount); | ||
| } | ||
|
|
||
| public R execute(T request, Function<T, R> processingFunc) { |
There was a problem hiding this comment.
where is the associated test?
arithmetization/src/main/java/net/consensys/linea/plugins/rpc/Requests.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/plugins/rpc/Requests.java
Outdated
Show resolved
Hide resolved
...etization/src/main/java/net/consensys/linea/plugins/rpc/linecounts/GenerateLineCountsV2.java
Outdated
Show resolved
Hide resolved
...src/main/java/net/consensys/linea/plugins/rpc/tracegeneration/GenerateConflatedTracesV2.java
Outdated
Show resolved
Hide resolved
powerslider
force-pushed
the
feat/issue-1240/req-limiting
branch
3 times, most recently
from
2fb9f5c
to
f03a980
Compare
powerslider
force-pushed
the
feat/issue-1240/req-limiting
branch
9 times, most recently
from
f334011
to
12d8961
Compare
lu-pinto
reviewed
Sep 23, 2024
arithmetization/src/main/java/net/consensys/linea/plugins/rpc/RequestLimiter.java
Outdated
Show resolved
Hide resolved
powerslider
force-pushed
the
feat/issue-1240/req-limiting
branch
2 times, most recently
from
dcf9f96
to
eeb384e
Compare
powerslider
force-pushed
the
feat/issue-1240/req-limiting
branch
from
eeb384e
to
210de3d
Compare
|
LGTM, I cannot ship it yet. Might be because I'm still not a maintainer for Besu |
lu-pinto
reviewed
Sep 23, 2024
| RequestLimiterDispatcher.getLimiter( | ||
| RequestLimiterDispatcher.SINGLE_INSTANCE_REQUEST_LIMITER_KEY); | ||
|
|
||
| return !requestLimiter.isNodeAtMaxCapacity() && synchronizationService.isInitialSyncPhaseDone(); |
There was a problem hiding this comment.
just as a side note to not forget isInitialSynchPhaseDone will not give what you are looking after but there's no other option right now.
I open up the isInSynch check that if the head of the chain is out of synch here: hyperledger/besu#7665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.