-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow users to transfer money to a .stark name #185
Comments
Hey @irisdv, I can work on it |
if the name not found, we should block it from the UI (the snap should already implemented a logic to block the txn) |
Ok will do ! I'd like to finish this issue, but I would need version of starknet.js above 6.3.0 so the |
The PR that upgrading the starknet.js to latest version, which is because of supporting TXN v3, however, we discover some bugs in starknet.js, and we resolved by local patching the PR is there #185 Yes, you can base on this PR, but we may not merge that soon, we have to merge the cairo contract upgrade first, i would suggest you to wait until the cairo contract upgrade merged, as it has some breaking change on UI too |
I saw that #219 upgrading starknet.js was merged. Was the cairo contract upgrade PR also merged ? |
No, the cairo contract PR has to re do some work due to library update |
Hi @irisdv , the Cairo contract PR has been merged to main. What is the status with this ? |
Ah great, then I'll update the PR I prepared and I'll make a PR this week on the repo if that's ok with you ? |
Sounds great! |
This feature will add support to sending money to a .stark domain within the app. Here is what it could look like:
Implementation proposal
To retrieve the address from the user stark name, we can call the function
domain_to_address
from the starknet ID naming contract. This function takes in argument an encoded domain as a felt array and returns the a Starknet address. You can find more information on our encoding and decoding algorithm here.This feature will follow a similar implementation than #184.
In starknet-snap :
starkNet_getAddrFromStarkName
In wallet-ui :
starkNet_getAddrFromStarkName
and use it SendModal componentAddressInput
component and thehandleChange
function to also accept a Stark nameIf a significant number of contributors agree with our approach I'll start working on Pull Request.
Please feel free to answer on this issue and tell me what you think !
The text was updated successfully, but these errors were encountered: