Add BlindBlockUtil for EIP-4844 #6532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ethereum/spec/src/test/java/tech/pegasys/teku/spec/logic/common/util/BlindBlockUtilTest.java
Fixed
Show fixed
Hide fixed
ajsutton
reviewed
Dec 2, 2022
| } | ||
|
|
||
| @Override | ||
| public SignedBeaconBlock blind(final SignedBeaconBlock signedUnblindedBock) { |
There was a problem hiding this comment.
Any reason we can't just use SignedBeaconBlock.blind method here?
There was a problem hiding this comment.
Nice question. Will check why it's not called also in Bellatrix, I've followed
|
As I removed most blind duplicated code I'm not sure we still need 3 classes there, but at least it checks that correct Schema definition is passed in |
tbenr
approved these changes
Dec 2, 2022
| .getOptionalExecutionPayloadHeader() | ||
| .orElseThrow() | ||
| .isHeaderOfDefaultPayload()) { | ||
| // Terminal block not reached, provide default payload |
There was a problem hiding this comment.
youre providing a random block, so you'll never fall in this code path so you can leave only the code in the else
|
|
||
| @TestTemplate | ||
| void shouldBlindAndUnblindBlock(final SpecContext specContext) { | ||
| final SignedBeaconBlock signedBeaconBlock = dataStructureUtil.randomSignedBeaconBlock(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Part of #6440:
BlindBlockUtilEip4844
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog