Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EIP-4844 to Deneb #6783

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Rename EIP-4844 to Deneb #6783

merged 4 commits into from
Feb 8, 2023

Conversation

zilm13
Copy link
Contributor

@zilm13 zilm13 commented Feb 7, 2023

PR Description

As per ethereum/consensus-specs#3215

Could be merged as is before configs are updated both in spec and in our code

Left 10 TODOs in most of:

  • rename config fork version and epoch, both in configs and getters keys (yamls, DenebBuilder.java)
  • rename reference tests keyword (TestFork.java), update runner hacks (TransitionTestExecutor.java, ForkUpgradeTestExecutor.java)
  • Update all CKZG stuff in this project to not expose 4844 out of the API
  • links to spec (BlobsSidecarsByRangeMessageHandler.java, FetchBlockAndBlobsSidecarTask.java)

It's possible to remove them and just left locations of parts needed to be cleaned in meta-issue

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi added the Epic Deneb Issues required to implement Deneb upgrade label Feb 7, 2023
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM or at least didn't see anything weird and the tests are passing 🤞
I'd suggest to add a checklist of the TODOs in the initial issue #6608
I guess it's better to merge it ASAP to avoid conflicts...

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@zilm13 zilm13 merged commit 360a4a4 into Consensys:master Feb 8, 2023
@zilm13 zilm13 deleted the eip4844-deneb branch February 8, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Deneb Issues required to implement Deneb upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants