Late Block reorg refactor #7911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed state from isHeadWeak and isParentStrong - these values now get cached on updateHeadTransaction Renamed newSlot to proposalSlot Added a function to cache weights, as they're expensive to compute and we shouldn't need to compute each call. debug logging added in recentChainData at decission points. partially addresses Consensys#6595 - this is a subset of Consensys#7789 Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
tbenr
reviewed
Jan 24, 2024
storage/src/main/java/tech/pegasys/teku/storage/client/RecentChainData.java
Show resolved
Hide resolved
storage/src/main/java/tech/pegasys/teku/storage/client/RecentChainData.java
Outdated
Show resolved
Hide resolved
...referenceTest/java/tech/pegasys/teku/reference/phase0/forkchoice/ForkChoiceTestExecutor.java
Show resolved
Hide resolved
lucassaldanha
approved these changes
Jan 24, 2024
Signed-off-by: Paul Harris <[email protected]>
…nto renames-from-late-block-reorg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed state from isHeadWeak and isParentStrong - these values now get cached on updateHeadTransaction
Renamed newSlot to proposalSlot
Added a function to cache weights, as they're expensive to compute and we shouldn't need to compute each call.
debug logging added in recentChainData at decission points.
partially addresses #6595 - this is a subset of #7789
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog