implement getStateForBlockProduction for late block reorg #7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently late block reorg is disabled so this defers to `getStateAtSlotExact` This functionality diverges from `getStateAtSlotExact` with late block reorg, as sometimes the state we're wanting to use is the parent of the head. In this scenario we actually need to check the proposer head, and get the appropriate state based on that instead. The fallback given all things being equal currently is to call getStateAtSlotExact, which is basically falling back to the old functionality. - if late block reorg is disabled - if the head root can't be read - if the headRoot is the same as the root we're told to use from getProposerHead. In late block reorg case where we're using parent, we need to call `regenerateBeaconState` to apply empty slots. partially addresses Consensys#6595 Signed-off-by: Paul Harris <[email protected]>
zilm13
approved these changes
Jan 30, 2024
storage/src/main/java/tech/pegasys/teku/storage/client/CombinedChainDataClient.java
Show resolved
Hide resolved
storage/src/test/java/tech/pegasys/teku/storage/client/CombinedChainDataClientTest.java
Outdated
Show resolved
Hide resolved
storage/src/test/java/tech/pegasys/teku/storage/client/CombinedChainDataClientTest.java
Outdated
Show resolved
Hide resolved
storage/src/test/java/tech/pegasys/teku/storage/client/CombinedChainDataClientTest.java
Outdated
Show resolved
Hide resolved
storage/src/test/java/tech/pegasys/teku/storage/client/CombinedChainDataClientTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently late block reorg is disabled so this defers to
getStateAtSlotExactThis functionality diverges from
getStateAtSlotExactwith late block reorg, as sometimes the state we're wanting to use is the parent of the head. In this scenario we actually need to check the proposer head, and get the appropriate state based on that instead.The fallback given all things being equal currently is to call getStateAtSlotExact, which is basically falling back to the old functionality.
In late block reorg case where we're using parent, we need to call
regenerateBeaconStateto apply empty slots.partially addresses #6595
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog