Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssz publishBlock sent without milestone header #8117

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

zilm13
Copy link
Contributor

@zilm13 zilm13 commented Mar 20, 2024

PR Description

It was reported that VC Teku fails to propose in connection with BN Lighthouse.
This happens because Teku sends requests without required header (see https://github.com/ethereum/beacon-APIs/blob/master/apis/beacon/blocks/blocks.yaml#L37 "Use content type header"). According to the API spec it should be used both for blind block and non-blind. Fixed with the PR.

Tested also (successfully) in Kurtosis with following configuration:

participants:
  - el_client_type: geth
    cl_type: lighthouse
    vc_type: teku
    vc_image: consensys/teku:develop
additional_services:
  - el_forkmon
  - tx_spammer
  - dora
snooper_enabled: true

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can possibly add changelog for bug fixes.

Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfyone
Copy link
Contributor

rolfyone commented Mar 21, 2024

this looks like we're still using the v1 block interface? I guess at some point this starts calling v3 and it needs that header too...

@zilm13 zilm13 merged commit e0222aa into Consensys:master Mar 21, 2024
16 checks passed
@zilm13 zilm13 deleted the fix-post-blocks-header branch March 21, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants