Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move web3 to peerDependencies #27

Merged
merged 6 commits into from
Sep 8, 2021
Merged

move web3 to peerDependencies #27

merged 6 commits into from
Sep 8, 2021

Conversation

VGLoic
Copy link
Contributor

@VGLoic VGLoic commented Sep 7, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ricardolyn
ricardolyn reviewed Sep 7, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@VGLoic VGLoic force-pushed the web3js-peer-dep branch 2 times, most recently from de4f7b7 to d6cfbd1 Compare September 7, 2021 09:48
@VGLoic VGLoic linked an issue Sep 7, 2021 that may be closed by this pull request
Integration of Snyk #20
Closed
2 tasks
@VGLoic
Copy link
Contributor Author

VGLoic commented Sep 7, 2021

Summary:

The web3 version has been updated to latest, some snapshot have been updated in consequence.

The peerDependency for web3 has been added with version 1.x.

The badge for vulnerabilities has been added to the README

achraf17
achraf17 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@achraf17 achraf17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ricardolyn
ricardolyn approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@ricardolyn ricardolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VGLoic VGLoic merged commit 76cb4b5 into master Sep 8, 2021
@VGLoic VGLoic deleted the web3js-peer-dep branch September 8, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achraf17 achraf17 achraf17 approved these changes

@ricardolyn ricardolyn ricardolyn approved these changes

@macfarla macfarla Awaiting requested review from macfarla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration of Snyk
4 participants
@VGLoic @CLAassistant @ricardolyn @achraf17