Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update c parameter to send both client version + app (customer) version #227

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update c parameter to send both client version + app (customer) version #227

wants to merge 2 commits into from

Conversation

mocca102
Copy link
Contributor

No description provided.

@mocca102 mocca102 requested a review from a team September 12, 2024 22:09
stanlp1
stanlp1 reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@stanlp1 stanlp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constructorio-client-swift/AutocompleteClientTests/Test Utils/Constants/TestConstants.swift

Line 16 in 45c7fac

let kRegexVersion = "cioios-[\\d\\.]*"

My Xcode is updating but I think we may need to update our test regex right? Otherwise the tests would fail.

jjl014
jjl014 requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jjl014 jjl014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, but the version info is swapped and we'll need to make some adjustments to the regex so the tests pass as Stanley mentioned

Screenshot 2024-09-26 at 4 10 01 PM

AutocompleteClient/Constants/Constants.swift
let constructorSDKVersion = Constants.getConstructorSDKVersion()
let customerAppVersion = Constants.getCustomerAppVersion()

return "\(prefix)\(customerAppVersion)::\(constructorSDKVersion)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The customerAppVersion and constructorSDKVersion are reversed. Let's swap them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanlp1 stanlp1 stanlp1 left review comments

@jjl014 jjl014 jjl014 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mocca102 @jjl014 @stanlp1