-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie Monster's notification sounds do not respect the vanilla volume setting #437
Comments
By the way, have you tested this yourself? I don't really know where to look for possible issues as I am not quite sure what could be the problem and not able to reproduce it. The new sounds use the same functions as the old ones and we did include "standard values" whenever they were not configured by the user themselves (standard value is 100%). |
The specific test I did was with the Garden. Using the debug upgrade "Turbo-charged soil", I get a notification every second, and the notification is as loud as possible even if I set the Vanilla volume slider to 0. The bug exists in https://cdn.rawgit.com/Aktanusa/CookieMonster/dev/CookieMonster.js. (I only referenced that Reddit post because it was not me who found the bug...) |
Ah okay! I am pretty sure the function in CookieMonster that creates the sounds currently does not check the Vanilla volume slider. |
Incorporated the general game volume in calculation of notifications volumes
This should now be fixed! :) |
Each notification sound has an option to adjust the volume, but they all ignore, for example, if the vanilla volume is set to 0.
(From https://www.reddit.com/r/CookieClicker/comments/kaefd4)
The text was updated successfully, but these errors were encountered: