Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Monster's notification sounds do not respect the vanilla volume setting #437

Closed
staticvariablejames opened this issue Dec 10, 2020 · 5 comments · Fixed by #439
Closed
Labels

Comments

@staticvariablejames
Copy link
Contributor

Each notification sound has an option to adjust the volume, but they all ignore, for example, if the vanilla volume is set to 0.

(From https://www.reddit.com/r/CookieClicker/comments/kaefd4)

@DanielNoord
Copy link
Collaborator

Thanks for making an issue, I do not always see posts on the reddit!

I don't think we will push a hot fix for this issue but rather fix it with the implementation of #26 (where you gave a good suggestion I saw).
#26 is scheduled for next release so the reporter shouldn't have to wait too long!

@DanielNoord
Copy link
Collaborator

By the way, have you tested this yourself?
After a quick look and test I wasn't able to easily reproduce this. They seem to work fine for me.

I don't really know where to look for possible issues as I am not quite sure what could be the problem and not able to reproduce it. The new sounds use the same functions as the old ones and we did include "standard values" whenever they were not configured by the user themselves (standard value is 100%).

@staticvariablejames
Copy link
Contributor Author

The specific test I did was with the Garden. Using the debug upgrade "Turbo-charged soil", I get a notification every second, and the notification is as loud as possible even if I set the Vanilla volume slider to 0. The bug exists in https://cdn.rawgit.com/Aktanusa/CookieMonster/dev/CookieMonster.js.

(I only referenced that Reddit post because it was not me who found the bug...)

@DanielNoord
Copy link
Collaborator

Ah okay! I am pretty sure the function in CookieMonster that creates the sounds currently does not check the Vanilla volume slider.
This is something we should clearly add.
I think that would also solve this bug as the individual volume settings per notification seem to work as intended.

DanielNoord added a commit that referenced this issue Dec 13, 2020
Incorporated the general game volume in calculation of notifications volumes
@DanielNoord
Copy link
Collaborator

This should now be fixed! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants