Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucky prestige stats #222

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

jshepler
Copy link
Contributor

Calculates when to reset to enable "Lucky Digit", "Lucky Number", and "Lucky Payout" upgrades on the ascension screen and shows the numbers on the stats view.

@jshepler jshepler changed the title added stats Lucky prestige stats Sep 20, 2018
@Aktanusa
Copy link
Collaborator

I'll take a look in a few days.

@Aktanusa
Copy link
Collaborator

So I've finally had some time to take a look and this looks very interesting! I really hope I can add this in the future. Thanks for your contribution!

@jshepler
Copy link
Contributor Author

Sure. Feel free to changing wording or rename variables. I'm pretty bad at wording/naming things. I looked at the commit to remind myself what this does and the stats' labels and variable names didn't make any sense considering what I think the intention is (showing number of remaining something before a reset should be done).

https://martinfowler.com/bliki/TwoHardThings.html

@Aktanusa
Copy link
Collaborator

Great link, lol.

@AmethystMoon
Copy link
Collaborator

I reviewed the code, and it looks good! I'll go ahead and merge it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants