Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redmine 5.x #96

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Redmine 5.x #96

wants to merge 21 commits into from

Conversation

artech-mg
Copy link

This is my first attempt to make this compatible with redmine 5. No ruby skills, so review is much appreciated.

@artech-mg
fix(redmine 5): modify init.rb; remove require calls
cc65b0b
@artech-mg
fix(redmine 5): replace around_filter with around_action
009c2c0
@artech-mg
fix(redmine 5): replace alias_method_chain with alias_method
f260c3b 
see rails/rails@a982a42
@artech-mg
fix(redmine 5): modify project structure
77636d3 
due to naming conventions
@artech-mg
fix(redmine 5): rename module to RedmineAdvancedRoadmap
035ce99
@artech-mg
fix(redmine 5): add migration version
78523fe
@artech-mg
fix(redmine 5): replace before_filter with before_action
bbc995c
@artech-mg
fix(redmine 5): migrate to strong parameters
cd1c1db 
see https://www.fastruby.io/blog/rails/upgrades/strong-parameters-migration-guide.html
@artech-mg
fix(redmine 5): move Magick definition to top of file to prevent Name…
89df2c7 
…Error

see https://stackoverflow.com/questions/8173214/ruby-module-nameerror-order-matters
@artech-mg
fix(redmine 5): fix NameErrors related to stacked_mixin
7418902
@artech-mg
fix(redmine 5): fix namespace errors related to Gruff
4499978
@artech-mg
fix(redmine 5): increase plugin version
e44836e
@artech-mg
fix(redmine 5): fix css hickups
0a47874
@artech-mg
fix(redmine 5): replace ActionView::Base.new
60013bd 
see https://stackoverflow.com/questions/70011135/render-js-erb-view-on-rails-6
@artech-mg
fix(redmine 5): replace render call in calenders_controller_patch
9044634
@artech-mg
fix(redmine 5): fix format specifier
8865bde 
see https://bugs.ruby-lang.org/issues/13761
@artech-mg
fix(redmine 5): insert milestones tab properly
b106dd6
@artech-mg
fix(redmine 5): fix gantt crash
4d47299
@artech-mg
fix(redmine 5): replace update_attributes with update
5e8cc4a 
see https://stackoverflow.com/questions/21605186/undefined-method-update-attributes-in-rails
@artech-mg
fix(redmine 5): replace exists with exist
a27618f 
see https://ruby-doc.org/core-2.2.0/File.html#exist-3F-method
@artech-mg
fix(redmine 5): add space below total progress bar
8fa5c6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@artech-mg