Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vulnerable dependencies #208

Merged
merged 17 commits into from
May 1, 2024

Conversation

masihyeganeh
Copy link
Contributor

@masihyeganeh masihyeganeh commented Apr 25, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@masihyeganeh masihyeganeh requested a review from a team as a code owner April 25, 2024 07:03
@masihyeganeh masihyeganeh requested review from dzmitryhil, miladz68, ysv and wojtek-coreum and removed request for a team April 25, 2024 07:03
Copy link
Contributor Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @wojtek-coreum, and @ysv)


contract/Cargo.toml line 39 at r1 (raw file):

sha2 = "0.10.8"
thiserror = "1.0.56"
libsecp256k1 = "0.5.0"

I'm not sure if adding new version of the transitive dependencies is going to make any difference here, but I can't find a good way to actually replace them. I'm aware of "patch"ing, but it seems that there is no standard way to upgrade them:
rust-lang/cargo#5640

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, @wojtek-coreum, and @ysv)


contract/Cargo.toml line 39 at r1 (raw file):

Previously, masihyeganeh (Masih Yeganeh) wrote…

I'm not sure if adding new version of the transitive dependencies is going to make any difference here, but I can't find a good way to actually replace them. I'm aware of "patch"ing, but it seems that there is no standard way to upgrade them:
rust-lang/cargo#5640

@keyleu WDYT ?

Copy link
Collaborator

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, @wojtek-coreum, and @ysv)


contract/Cargo.toml line 39 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

@keyleu WDYT ?

I don't think this is going to make any difference. The only "important" one even though we are also not affected is the cosmwasm-std one. I think we can remove the rest.

dzmitryhil
dzmitryhil previously approved these changes Apr 25, 2024
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @miladz68, @wojtek-coreum, and @ysv)

keyleu
keyleu previously approved these changes Apr 25, 2024
Copy link
Collaborator

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 7 files at r1, 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68, @wojtek-coreum, and @ysv)

miladz68
miladz68 previously approved these changes Apr 26, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 7 files at r1, 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

@masihyeganeh masihyeganeh dismissed stale reviews from miladz68 and keyleu via c2838b0 April 26, 2024 09:28
miladz68
miladz68 previously approved these changes Apr 26, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

dzmitryhil
dzmitryhil previously approved these changes Apr 26, 2024
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, 5 of 5 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

ysv
ysv previously approved these changes Apr 26, 2024
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, 5 of 5 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@masihyeganeh masihyeganeh dismissed stale reviews from ysv and dzmitryhil via 18c8a4d April 29, 2024 12:48
@masihyeganeh masihyeganeh force-pushed the masih/upgrade-vulnerable-dependencies branch from 1c316e0 to 18c8a4d Compare April 29, 2024 12:48
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @wojtek-coreum)


.DS_Store line 0 at r6 (raw file):
ignore ?

Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @wojtek-coreum)


.DS_Store line at r6 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

ignore ?

eventually we had a rule that we add only project-specific files to .gitignore e.g wasm binaries etc
But global things which are dependent on system etc we prefer everyone to have .gitignore_global and put there any files specific for their system etc

Copy link
Contributor Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r7.
Reviewable status: 5 of 11 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)


.DS_Store line at r6 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

eventually we had a rule that we add only project-specific files to .gitignore e.g wasm binaries etc
But global things which are dependent on system etc we prefer everyone to have .gitignore_global and put there any files specific for their system etc

Done.

ysv
ysv previously approved these changes Apr 30, 2024
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 7 files at r7, 7 of 7 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

ysv
ysv previously approved these changes Apr 30, 2024
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

Copy link
Contributor Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, 1 of 7 files at r7, 5 of 7 files at r8, 3 of 3 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

miladz68
miladz68 previously approved these changes Apr 30, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r7, 5 of 7 files at r8, 3 of 3 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@masihyeganeh masihyeganeh dismissed stale reviews from miladz68 and ysv via 5553538 April 30, 2024 16:52
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@masihyeganeh masihyeganeh merged commit bad1290 into master May 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants