Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nargs #669

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Remove nargs #669

merged 1 commit into from
Sep 1, 2024

Conversation

ihfazhillah
Copy link
Contributor

Remove nargs in the create_public_tenant!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Other Information

When creating a public tenant using the management command, the system can't find any domain registered in our database. Checked the database, the domain and the email returns a stringified list.

The problem on the nargs parameter in the add_argument method. Per documentation

N arguments from the command line will be gathered together into a list.

@Dresdn
Copy link
Collaborator

Dresdn commented Sep 1, 2024

Good catch @ihfazhillah - thanks for the PR!

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (2b2c385) to head (693cebd).
Report is 87 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #669       +/-   ##
===========================================
+ Coverage   88.36%   99.77%   +11.40%     
===========================================
  Files          18       26        +8     
  Lines         619      875      +256     
  Branches      116      144       +28     
===========================================
+ Hits          547      873      +326     
+ Misses         62        1       -61     
+ Partials       10        1        -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dresdn Dresdn merged commit d11c2ed into Corvia:master Sep 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants