Skip to content

Commit

Permalink
🔧 Modifier issues on the iosMain side of the code have been addressed.
Browse files Browse the repository at this point in the history
  • Loading branch information
Corvus400 committed Aug 22, 2024
1 parent a82966a commit f77487e
Show file tree
Hide file tree
Showing 69 changed files with 38 additions and 36 deletions.
2 changes: 1 addition & 1 deletion app-android/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ dependencies {
implementation(projects.core.model)
implementation(projects.core.data)
implementation(projects.core.designsystem)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(libs.composeNavigation)
implementation(libs.composeHiltNavigation)
implementation(libs.composeMaterialWindowSize)
Expand Down
2 changes: 1 addition & 1 deletion app-ios-shared/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ kotlin {
dependencies {
api(projects.core.model)
api(projects.core.data)
api(projects.core.ui)
api(projects.core.droidkaigiui)
api(projects.feature.main)
api(projects.feature.sessions)
api(projects.feature.eventmap)
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ plugins {
id("droidkaigi.primitive.detekt")
}

android.namespace = "io.github.droidkaigi.confsched.core.ui"
// https://github.com/DroidKaigi/conference-app-2024/issues/485#issuecomment-2304251937
// (KT-66568)[https://youtrack.jetbrains.com/issue/KT-66568/w-KLIB-resolver-The-same-uniquename...-found-in-more-than-one-library]
android.namespace = "io.github.droidkaigi.confsched.core.droidkaigiui"

kotlin {
sourceSets {
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.graphics.painter.Painter
import conference_app_2024.core.ui.generated.resources.about_header_title
import io.github.droidkaigi.confsched.core.ui.R
import conference_app_2024.core.droidkaigiui.generated.resources.about_header_title
import io.github.droidkaigi.confsched.core.droidkaigiui.R
import org.jetbrains.compose.resources.painterResource

@OptIn(ExperimentalAnimationGraphicsApi::class)
Expand All @@ -32,6 +32,6 @@ actual fun provideAboutHeaderTitlePainter(enableAnimation: Boolean): Painter {

painter
} else {
painterResource(UiRes.drawable.about_header_title)
painterResource(DroidKaigiUiRes.drawable.about_header_title)
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.github.droidkaigi.confsched.ui

import androidx.compose.runtime.Composable
import conference_app_2024.core.ui.generated.resources.connection_failed
import conference_app_2024.core.droidkaigiui.generated.resources.connection_failed
import io.github.droidkaigi.confsched.model.AppError
import io.github.droidkaigi.confsched.model.AppError.InternetConnectionException
import org.jetbrains.compose.resources.stringResource
Expand All @@ -14,7 +14,7 @@ import kotlin.reflect.KClass
internal fun composeResourceErrorMessages(): List<ComposeResourceErrorMessage> = listOf(
ComposeResourceErrorMessage(
InternetConnectionException::class,
stringResource(UiRes.string.connection_failed),
stringResource(DroidKaigiUiRes.string.connection_failed),
),
)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package io.github.droidkaigi.confsched.ui

import conference_app_2024.core.ui.generated.resources.Res
import conference_app_2024.core.droidkaigiui.generated.resources.Res

object UiRes {
object DroidKaigiUiRes {
val string = Res.string
val drawable = Res.drawable
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@ import androidx.compose.ui.text.buildAnnotatedString
import androidx.compose.ui.text.style.TextDecoration
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import conference_app_2024.core.ui.generated.resources.bookmarked
import conference_app_2024.core.ui.generated.resources.image
import conference_app_2024.core.ui.generated.resources.not_bookmarked
import conference_app_2024.core.droidkaigiui.generated.resources.bookmarked
import conference_app_2024.core.droidkaigiui.generated.resources.image
import conference_app_2024.core.droidkaigiui.generated.resources.not_bookmarked
import io.github.droidkaigi.confsched.designsystem.theme.ProvideRoomTheme
import io.github.droidkaigi.confsched.designsystem.theme.primaryFixed
import io.github.droidkaigi.confsched.model.TimetableItem
import io.github.droidkaigi.confsched.model.TimetableItem.Session
import io.github.droidkaigi.confsched.ui.UiRes
import io.github.droidkaigi.confsched.ui.DroidKaigiUiRes
import io.github.droidkaigi.confsched.ui.animation.LocalFavoriteAnimationScope
import io.github.droidkaigi.confsched.ui.rememberAsyncImagePainter
import org.jetbrains.compose.resources.stringResource
Expand Down Expand Up @@ -136,7 +136,7 @@ fun TimetableItemCard(
BorderStroke(1.dp, MaterialTheme.colorScheme.outline),
CircleShape,
),
contentDescription = stringResource(UiRes.string.image),
contentDescription = stringResource(DroidKaigiUiRes.string.image),
)
Text(
text = speaker.name,
Expand All @@ -160,7 +160,7 @@ fun TimetableItemCard(
) {
Icon(
Icons.Filled.Info,
contentDescription = stringResource(UiRes.string.image),
contentDescription = stringResource(DroidKaigiUiRes.string.image),
tint = MaterialTheme.colorScheme.error,
)
Text(
Expand Down Expand Up @@ -208,15 +208,15 @@ private fun FavoriteButton(
if (isBookmarked) {
Icon(
Filled.Favorite,
contentDescription = stringResource(UiRes.string.bookmarked),
contentDescription = stringResource(DroidKaigiUiRes.string.bookmarked),
tint = MaterialTheme.colorScheme.primaryFixed,
modifier = Modifier
.testTag(TimetableItemCardBookmarkedIconTestTag),
)
} else {
Icon(
Outlined.FavoriteBorder,
contentDescription = stringResource(UiRes.string.not_bookmarked),
contentDescription = stringResource(DroidKaigiUiRes.string.not_bookmarked),
tint = MaterialTheme.colorScheme.onSurfaceVariant,
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ package io.github.droidkaigi.confsched.ui

import androidx.compose.runtime.Composable
import androidx.compose.ui.graphics.painter.Painter
import conference_app_2024.core.ui.generated.resources.about_header_title
import conference_app_2024.core.droidkaigiui.generated.resources.about_header_title
import org.jetbrains.compose.resources.painterResource

@Composable
actual fun provideAboutHeaderTitlePainter(enableAnimation: Boolean): Painter {
return painterResource(UiRes.drawable.about_header_title)
return painterResource(DroidKaigiUiRes.drawable.about_header_title)
}
2 changes: 1 addition & 1 deletion core/testing-manifest/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ plugins {
android.namespace = "io.github.droidkaigi.confsched.core.testing"

dependencies {
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
}
2 changes: 1 addition & 1 deletion core/testing/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies {
implementation(projects.core.model)
implementation(projects.core.designsystem)
implementation(projects.core.data)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(projects.feature.main)
implementation(projects.feature.sessions)
implementation(projects.feature.profilecard)
Expand Down
2 changes: 1 addition & 1 deletion feature/about/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ kotlin {
commonMain {
dependencies {
implementation(projects.core.designsystem)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(projects.core.model)

implementation(libs.composeNavigation)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ import androidx.compose.ui.layout.ContentScale
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.unit.dp
import conference_app_2024.core.ui.generated.resources.about_header_year
import conference_app_2024.core.droidkaigiui.generated.resources.about_header_year
import conference_app_2024.feature.about.generated.resources.description
import io.github.droidkaigi.confsched.about.AboutRes
import io.github.droidkaigi.confsched.about.component.AboutDroidKaigiDetailSummaryCard
import io.github.droidkaigi.confsched.designsystem.theme.KaigiTheme
import io.github.droidkaigi.confsched.ui.UiRes
import io.github.droidkaigi.confsched.ui.DroidKaigiUiRes
import io.github.droidkaigi.confsched.ui.canShowLargeVector
import io.github.droidkaigi.confsched.ui.provideAboutHeaderTitlePainter
import org.jetbrains.compose.resources.painterResource
Expand Down Expand Up @@ -74,7 +74,7 @@ fun AboutDroidKaigiDetail(
Modifier
}
Image(
painter = painterResource(UiRes.drawable.about_header_year),
painter = painterResource(DroidKaigiUiRes.drawable.about_header_year),
contentDescription = null,
contentScale = ContentScale.FillWidth,
modifier = imageModifier,
Expand Down
2 changes: 1 addition & 1 deletion feature/contributors/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ kotlin {
commonMain {
dependencies {
implementation(projects.core.model)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(libs.kotlinxCoroutinesCore)
implementation(projects.core.designsystem)
implementation(libs.moleculeRuntime)
Expand Down
2 changes: 1 addition & 1 deletion feature/eventmap/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ kotlin {
commonMain {
dependencies {
implementation(projects.core.model)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(projects.core.designsystem)

implementation(libs.kotlinxCoroutinesCore)
Expand Down
2 changes: 1 addition & 1 deletion feature/favorites/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ kotlin {
commonMain {
dependencies {
implementation(projects.core.model)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(libs.kotlinxCoroutinesCore)
implementation(projects.core.designsystem)
implementation(libs.moleculeRuntime)
Expand Down
2 changes: 1 addition & 1 deletion feature/main/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ kotlin {
implementation(compose.materialIconsExtended)
implementation(projects.core.model)
implementation(projects.core.designsystem)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(libs.haze)
}
}
Expand Down
2 changes: 1 addition & 1 deletion feature/profilecard/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ kotlin {
commonMain {
dependencies {
implementation(projects.core.designsystem)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(projects.core.model)

implementation(libs.composeNavigation)
Expand Down
2 changes: 1 addition & 1 deletion feature/sessions/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ kotlin {
commonMain {
dependencies {
implementation(projects.core.designsystem)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(projects.core.model)

implementation(libs.kotlinSerializationJson)
Expand Down
2 changes: 1 addition & 1 deletion feature/settings/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ kotlin {
commonMain {
dependencies {
implementation(projects.core.model)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(projects.core.designsystem)

implementation(libs.kotlinxCoroutinesCore)
Expand Down
2 changes: 1 addition & 1 deletion feature/sponsors/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ kotlin {
commonMain {
dependencies {
implementation(projects.core.model)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(libs.kotlinxCoroutinesCore)
implementation(projects.core.designsystem)
implementation(libs.moleculeRuntime)
Expand Down
2 changes: 1 addition & 1 deletion feature/staff/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ kotlin {
commonMain {
dependencies {
implementation(projects.core.model)
implementation(projects.core.ui)
implementation(projects.core.droidkaigiui)
implementation(libs.kotlinxCoroutinesCore)
implementation(projects.core.designsystem)
implementation(libs.moleculeRuntime)
Expand Down
2 changes: 1 addition & 1 deletion settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ include(
":core:designsystem",
":core:data",
":core:model",
":core:ui",
":core:droidkaigiui",
":core:testing",
":core:testing-manifest",
":core:common",
Expand Down

0 comments on commit f77487e

Please sign in to comment.