Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awesome-list integration #24

Closed
wants to merge 7 commits into from

Conversation

merdoyovski
Copy link

Several changes for awesome-list compatibility are applied

  • Reworded long and some informal phrases
  • Made main hyperlinks forward to GitHub repos, adding visual links for crates.
  • Removed whitespace formatting done by prettier as it creates conflicts against awesome-lint
  • Updated dead and wrong links. Removed duplicate ones.
  • Updated contribution.md with awesome-lint suggestion.

This PR is a follow-up for the file changes mentioned in issue #22. After this is merged, the repository settings mentioned in the issue can be applied.
@uint

@uint uint requested review from uint and pyramation November 22, 2022 14:32
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I appreciate the more succinct phrasing, typo fixes, badges, and everything.

If we're switching to a different linter, would you mind deleting .prettierrc.json while we're here? It would be misleading now.

@uint uint self-requested a review November 22, 2022 20:36
@merdoyovski
Copy link
Author

You're right. I deleted the old linter file and added the .yml config file for the automatic PR check.

@merdoyovski merdoyovski requested review from uint and removed request for pyramation November 23, 2022 06:39
@merdoyovski
Copy link
Author

Re-requesting a review automatically removed @pyramation from reviewers and I don't have the authority to add him again. FYI.

@uint uint requested a review from pyramation November 23, 2022 07:48
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good!

@deus-labs deus-labs closed this by deleting the head repository Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants