Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Parse additional parameters for sv::msg(reply) (#426) #433

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat: Parse additional parameters for sv::msg(reply) (#426) #433

merged 2 commits into from
Sep 17, 2024

Conversation

jawoznia
Copy link
Collaborator

New optional parameters:
- handlers - (handler1, handler2, ..)
- reply_on - success|failure|always

@jawoznia
feat: Parse additional parameters for sv::msg(reply) (#426)
eac7534 
New optional parameters:
    - handlers - (handler1, handler2, ..)
    - reply_on - success|failure|always
@codecov Codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.21951% with 20 lines in your changes missing coverage. Please review.

Project coverage is 69.83%. Comparing base (10e8eb9) to head (44ab0c4).
Report is 2 commits behind head on feat/replies.

Files with missing lines Patch % Lines
sylvia/tests/reply.rs 0.00% 14 Missing ⚠️
sylvia-derive/src/parser/attributes/msg.rs 77.77% 6 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           feat/replies     #433      +/-   ##
================================================
- Coverage         70.08%   69.83%   -0.25%     
================================================
  Files                53       54       +1     
  Lines              3085     3120      +35     
================================================
+ Hits               2162     2179      +17     
- Misses              923      941      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia
Copy link
Collaborator Author

jawoznia commented Sep 3, 2024

closes #426

@jawoznia jawoznia linked an issue Sep 3, 2024 that may be closed by this pull request
Parse #[sv::msg(reply=alias1|alias2, reply_on=...)] #426
Open
kulikthebird
kulikthebird reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one comment to consider berfore we move on

sylvia/tests/reply.rs Outdated Show resolved Hide resolved
@jawoznia
chore: Review fix
44ab0c4 
Pass handlers bracketed instead of parenthesized
kulikthebird
kulikthebird approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jawoznia jawoznia merged commit 71e5a76 into feat/replies Sep 17, 2024
7 of 9 checks passed
@jawoznia jawoznia deleted the jawoznia/feat/parse_msg_reply branch September 17, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulikthebird kulikthebird kulikthebird approved these changes

@hashedone hashedone Awaiting requested review from hashedone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse #[sv::msg(reply=alias1|alias2, reply_on=...)]
2 participants
@jawoznia @kulikthebird