Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move constants to params #202

Closed
4 tasks
alpe opened this issue Jul 17, 2020 · 6 comments
Closed
4 tasks

Move constants to params #202

alpe opened this issue Jul 17, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@alpe
Copy link
Contributor

alpe commented Jul 17, 2020 •
edited
Loading

Summary

We have a couple of hard coded values that could be moved into params so that we can update them without deployment.
An incomplete list:

  • max contract size
  • gas multiplier
  • instance cost
  • compile cost
    ...

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alpe alpe changed the title More params Move constants to params Jul 17, 2020
@ethanfrey
Copy link
Member

Great ideas. Use the current constants as defaults and allow governance to adjust it.

@ethanfrey
Copy link
Member

Note: I will have to implement CosmWasm/wasmvm#122 before it is safe to change GasMultiplier. Let's wait on this until I update go-cosmwasm

@alpe alpe self-assigned this Jul 28, 2020
@alpe alpe mentioned this issue Jul 28, 2020
Closed
@alpe
Copy link
Contributor Author

alpe commented Aug 18, 2020

We have closed the PR and postpone this feature

@ethanfrey ethanfrey added this to the v2.0.0 milestone Aug 19, 2020
@alpe alpe removed their assignment Dec 9, 2020
@alpe alpe added the enhancement New feature or request label Dec 14, 2020
@ethanfrey ethanfrey mentioned this issue Jan 7, 2021
Merged
@alpe alpe removed this from the v2.0.0 milestone Jan 29, 2021
@alpe alpe added this to the v2.0.0 milestone Oct 18, 2021
@ethanfrey
Copy link
Member

This is related to #809

We need some of these values in the stateless ValidateBasic functions. That will make usage of Params impossible.

As a first step, I would propose pulling them into module-level var rather than const.
Projects importing x/wasm could then customize them either by runtime flags or by setting them explicitly in their custom app.go or cmd/*/main.go

@ethanfrey ethanfrey mentioned this issue Apr 25, 2022
Closed
@alpe
Copy link
Contributor Author

alpe commented Apr 25, 2022

I think we can close this and build a solution with #813.

zemyblue pushed a commit to Finschia/wasmd that referenced this issue Jan 2, 2023
Add -trimpath for enhanced build reproducibility (CosmWasm#202)
3733383 
See https://golang.org/cmd/go/#hdr-Compile_packages_and_dependencies
and https://golang.org/doc/go1.13#go-command for more information.

This does not replace the reproducible build infrastructure still it
should enable users to generate locally reproducible builds.
@alpe
Copy link
Contributor Author

alpe commented Mar 3, 2023

Closing this now as this was done with the gas register. MaxLabelSize, MaxWasmSize, MaxProposalWasmSize are vars in types/validation.go

@alpe alpe closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move constants to params CosmWasm/wasmd
2 participants
@alpe @ethanfrey