Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow proto dir best practice (in cosmos eco) #342

Closed
alpe opened this issue Dec 14, 2020 · 2 comments · Fixed by #466
Closed

Follow proto dir best practice (in cosmos eco) #342

alpe opened this issue Dec 14, 2020 · 2 comments · Fixed by #466
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented Dec 14, 2020

I found more and more projects that store the protobuf files into

  • proto/ - for their own files
  • third_party/proto - for the dependencies

This will make it easier to maintain multiple versions in the future but also works more nicely with buf linter.
On the downside these folders are not resolved by the Golang IDE automatically for dependencies.

@ethanfrey
Copy link
Member

I like this idea. I've never had much IDE support for proto files, so I won't miss it (as long as the generated *.pb.go files work with the IDE).

@alpe alpe added documentation Improvements or additions to documentation good first issue Good for newcomers and removed good first issue Good for newcomers labels Dec 14, 2020
@willclarktech
Copy link

This would also align us with Cosmos SDK.

@alpe alpe added this to the v0.16.0 milestone Jan 29, 2021
@alpe alpe self-assigned this Mar 19, 2021
@alpe alpe closed this as completed in #466 Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants