Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure protobuf files #466

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Restructure protobuf files #466

merged 2 commits into from
Mar 22, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 19, 2021

Resolves #342

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #466 (87e049d) into master (d914266) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   56.76%   56.80%   +0.04%     
==========================================
  Files          40       40              
  Lines        4385     4385              
==========================================
+ Hits         2489     2491       +2     
+ Misses       1685     1684       -1     
+ Partials      211      210       -1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 86.51% <0.00%> (+0.40%) ⬆️

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think we should stick with v1beta1 until we tag wasmd 1.0

proto/cosmwasm/wasm/v1beta1/proposal.proto Show resolved Hide resolved
Makefile Show resolved Hide resolved
-I "proto" \
-I "third_party/proto" \
--doc_out=./docs/proto \
--doc_opt=./docs/proto/protodoc-markdown.tmpl,proto-docs.md \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this diff, proto.md was renamed to proto-docs.md but proto.md was not removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow proto dir best practice (in cosmos eco)
3 participants