update interface proto annotations #1156
Conversation
proto/cosmwasm/wasm/v1/authz.proto
Outdated
| @@ -85,14 +85,14 @@ message CombinedLimit { | |||
| // message. | |||
| // Since: wasmd 0.30 | |||
| message AllowAllMessagesFilter { | |||
| option (cosmos_proto.implements_interface) = "ContractAuthzFilterX"; | |||
| option (cosmos_proto.implements_interface) = "cosmwasm.wasm.ContractAuthzFilterX"; | |||
There was a problem hiding this comment.
would this make it cosmwasm.wasm.ContractAuthzFilterX?
proto/cosmwasm/wasm/v1/authz.proto
Outdated
| @@ -57,7 +57,7 @@ message MaxCallsLimit { | |||
| // MaxFundsLimit defines the maximal amounts that can be sent to the contract. | |||
| // Since: wasmd 0.30 | |||
| message MaxFundsLimit { | |||
| option (cosmos_proto.implements_interface) = "ContractAuthzLimitX"; | |||
| option (cosmos_proto.implements_interface) = "cosmwasm.wasm.ContractAuthzLimitX"; | |||
There was a problem hiding this comment.
would this make it cosmwasm.wasm.ContractAuthzLimitX?
There was a problem hiding this comment.
You should have the version number here, too: cosmwasm.wasm.v1.ContractAuthzLimitX
proto/cosmwasm/wasm/v1/types.proto
Outdated
| @@ -90,7 +90,7 @@ message ContractInfo { | |||
| // Extension is an extension point to store custom metadata within the | |||
| // persistence model. | |||
| google.protobuf.Any extension = 7 | |||
| [ (cosmos_proto.accepts_interface) = "ContractInfoExtension" ]; | |||
| [ (cosmos_proto.accepts_interface) = "cosmwasm.wasm.ContractInfoExtension" ]; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks a lot for this PR. Too bad that I did all of this in #1149 already for sdk 0.47 as well as adding the signer annotation. Merging your PR will create merge conflicts for the sdk 0.47 branch.
Are the annotations something you need already in the next wasmd release or can this wait?
if yes, please add the version to the cosmwasm interface names and run make proto-all
proto/cosmwasm/wasm/v1/authz.proto
Outdated
| @@ -57,7 +57,7 @@ message MaxCallsLimit { | |||
| // MaxFundsLimit defines the maximal amounts that can be sent to the contract. | |||
| // Since: wasmd 0.30 | |||
| message MaxFundsLimit { | |||
| option (cosmos_proto.implements_interface) = "ContractAuthzLimitX"; | |||
| option (cosmos_proto.implements_interface) = "cosmwasm.wasm.ContractAuthzLimitX"; | |||
There was a problem hiding this comment.
You should have the version number here, too: cosmwasm.wasm.v1.ContractAuthzLimitX
Ideally we can get these ASAP, I'd be down to help make another PR to avoid the conflicts. Let me know the best approach! |
|
Thanks for the updates! Not sure how to address the merge issues with #1149 afterwards. I may simply revert this PR so let's make sure #1149 contains all the proto options that you need, too. |
|
@pyramation please see my last comment, to get this into v0.31.0 |
should I maybe do this again, but branch off of #1149 ? |
|
@pyramation just run I would like to get #1149 (which includes all the protobuf options of this PR already) into main as soon as the release is cut. |
|
fyi: I have tagged a rc0 release. There is still time on Monday to get this into the final one |
|
Kudos, SonarCloud Quality Gate passed!
|
|
great! I just ran the |
|
👍 Thanks for the updates! 💯 |
* main: (36 commits) Add changelog for v0.31.0 (#1188) Upgrade to wasmvm 1.2.1 (#1245) Bump bufbuild/buf-setup-action from 1.15.0 to 1.15.1 Make `CaptureIbcEvents` in ibctesting public. Fix client checksum verification (#1234) Test rust panic for regression Return IBC packet sequence number (#1225) Rename windows client binary Configure sonarcloud analysis Bump github.com/cosmos/gogoproto from 1.4.3 to 1.4.6 Add Windows client support (#1197) Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.1 to 1.0.0-beta.2 Bump bufbuild/buf-setup-action from 1.14.0 to 1.15.0 Bump SDK version to v0.45.14 Bump bufbuild/buf-setup-action from 1.13.1 to 1.14.0 (#1200) Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 (#1211) test: add unit test fix: stargate querier does not reset the state list-contract-by-code bugfix update interface proto annotations (#1156) ...
closes #1155