Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate server and windows client #1226

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Separate server and windows client #1226

merged 1 commit into from
Mar 3, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 3, 2023

Some personal preferences for better dev UX

  • rename build target and artifact to be more precise what is built
  • add error message to default build target

Untested

@alpe alpe requested a review from pinosu March 3, 2023 08:54
pinosu
pinosu approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and it works fine. Nice work! 👍

@alpe alpe merged commit bb923ad into 1169-build_windows_client Mar 3, 2023
@alpe alpe deleted the 1169-build_windows_client_review branch March 3, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu