linting 47 pr #1261

faddat · 2023-03-15T10:10:36Z

This PR lints the sdk 47 work, including tests.

It also includes #1259 since I think that'll merge into develop_sdk47 first.

alpe · 2023-03-15T10:52:14Z

Thank you for your help! We are working hard to bring the 47 dev branch to main. If you can help with code reviews, that would be very much appreciated at this stage.
When 47 is in main, I would be happy to merge the linter fixes on the prod code so that we have this addressed, too. Otherwise we keep fighting merge conflicts that make our work harder. Please bare with us.

faddat · 2023-03-15T11:35:01Z

Linting is part of how I review code. It's actually what I do before doing that, because it makes the code easier to review and makes the editor automatically highlight small things that could otherwise be missed in review.

This won't cause merge conflicts, as I have merged in both branches now.

It will, however, check many additional error cases.

alpe

Thanks for the work! 💐
I added some minor comments. I am wondering now, why the test is failing. It does not look related to your changes.

x/wasm/keeper/proposal_integration_test.go

x/wasm/keeper/reflect_test.go

x/wasm/types/genesis_test.go

x/wasm/types/types_test.go

.golangci.yml

x/wasm/client/cli/new_tx.go

x/wasm/keeper/ante_test.go

x/wasm/keeper/handler_plugin_encoders_test.go

.golangci.yml

x/wasm/genesis_test.go

Co-authored-by: Alexander Peters <[email protected]>

…-47-pr

faddat · 2023-03-15T12:41:54Z

I've merged #1263 here, as well.

codecov · 2023-03-15T13:29:47Z

Codecov Report

Merging #1261 (9c8678d) into develop_sdk47 (2eaa893) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@                Coverage Diff                @@
##           develop_sdk47    #1261      +/-   ##
=================================================
- Coverage          59.45%   59.43%   -0.03%     
=================================================
  Files                 57       57              
  Lines               7326     7326              
=================================================
- Hits                4356     4354       -2     
- Misses              2656     2657       +1     
- Partials             314      315       +1

Impacted Files	Coverage Δ
app/app.go	`86.27% <0.00%> (ø)`
app/export.go	`12.00% <0.00%> (ø)`
x/wasm/client/cli/gov_tx.go	`13.07% <0.00%> (ø)`
x/wasm/client/cli/new_tx.go	`0.00% <0.00%> (ø)`
x/wasm/types/keys.go	`60.71% <ø> (ø)`
app/upgrades.go	`74.00% <100.00%> (ø)`
x/wasm/module.go	`39.02% <100.00%> (ø)`
x/wasm/types/codec.go	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

alpe

Minor nit but happy to merge this now. Thanks for pushing this forward!

x/wasm/keeper/handler_plugin_encoders_test.go

x/wasm/keeper/reflect_test.go

* Start cosmos-sdk v0.47 integration (#1136) * Upgrade to sdk v0.47 branch * More integration work * SDK version upgrade; fixes * More fixes * Fixes * Deactivate failing tests * SDK + ibc-go version upgrades * limix gas fix (cherry picked from commit f7f8417) * with valset in bench (cherry picked from commit 35b2a8f) * Revert staking query handler; fix tests * Minor cleanup * Rebased * Address linter issues * Set legacy router proper * Deactivate failing test. Race condition needs to handled in SDK * Address some code smells * Bump sdk version * Use gov v1 internally for votes * Activate test after sdk fix * Add group test * Add config template for wasm fields * Add Rust backtrace flag for more debug output on simulations * Set unique node folder for tests * Revert "Add Rust backtrace flag for more debug output on simulations" This reverts commit 218c3c6. * Simulations * Run also im/export + deterministic sims * Add package prefix to interfaces * Add signer annotation (cosmos/cosmos-sdk#10933), minor cleanup * Bump sdk version * Review comments Co-authored-by: vuong <[email protected]> * Bump bufbuild/buf-setup-action from 1.11.0 to 1.12.0 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.11.0...v1.12.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit f490595) * Remove intertx for vanilla ICA * fix msg format in EVENTS.md (cherry picked from commit 38d466a) * Better to sdk coin convertion (#1164) * Better to sdk coin convertion * Review feedback (cherry picked from commit a925a9e) * Disallow only address permission (#1163) * Remove AccessTypeOnlyAddress for store msg * Remove AccessTypeOnlyAddress for update config msg * Review feedback Co-authored-by: Simon Warta <[email protected]> Co-authored-by: Simon Warta <[email protected]> (cherry picked from commit 8991633) * Integrate wasmvm v1.2.0 (backport #1161) (#1175) * Integrate wasmvm v1.2.0 (#1161) * Bump wasmvm version * Bump wasm test contracts * Encode weighted votes * Encode instantiate2 * Handle code info query; better wasmvm errors * Fix readme * Make linter happy * add non cgo build * Review comments * Bump wasmvm to release version Co-authored-by: jhernandezb <[email protected]> (cherry picked from commit 957b38e) # Conflicts: # x/wasm/keeper/handler_plugin_encoders.go # x/wasm/keeper/handler_plugin_encoders_test.go # x/wasm/keeper/keeper.go # x/wasm/keeper/keeper_test.go * Adress merge conflicts Co-authored-by: Alexander Peters <[email protected]> * Bump bufbuild/buf-setup-action from 1.12.0 to 1.13.0 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.12.0 to 1.13.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.12.0...v1.13.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit ffa0e5e) * Emit events for setContractAdmin + setAccessConfig (#1179) (cherry picked from commit c9e7830) * Dependency upgrades (#1172) * Bump sdk version to lastest * Bump ibc-go version to lastest * Remove channel hack * Update to ibc-go v7 + protoVer=0.11.5 * Bump bufbuild/buf-setup-action from 1.13.0 to 1.13.1 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.13.0 to 1.13.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.13.0...v1.13.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit de27e7f) * Fix typos (backport #1185) (#1194) * Fix typos (cherry picked from commit c88b819) # Conflicts: # proto/cosmwasm/wasm/v1/tx.proto * Fix merge conflict --------- Co-authored-by: Alex Peters <[email protected]> * Bump bufbuild/buf-setup-action from 1.13.1 to 1.14.0 (#1200) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.13.1 to 1.14.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.13.1...v1.14.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit f3fc31c) * list-contract-by-code bugfix (cherry picked from commit 2ccffed) * fix: stargate querier does not reset the state (cherry picked from commit fd03235) * test: add unit test (cherry picked from commit 6d8018a) * Add Windows client support (#1197) * Add Windows client support * Separate server and windows client --------- Co-authored-by: Alex Peters <[email protected]> (cherry picked from commit 8a20779) * Bump bufbuild/buf-setup-action from 1.14.0 to 1.15.0 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit e5fab3d) * Rename windows client binary (cherry picked from commit de09c7f) * Return IBC packet sequence number (backport #1225) (#1233) * Return IBC packet sequence number (#1225) * Return IBC packet sequence number * Fix review feedbacks * Remove names to return values in DispatchMsg method * Fix comments (cherry picked from commit 4f1c57f) # Conflicts: # x/wasm/keeper/handler_plugin.go * Fix merge conflict --------- Co-authored-by: pinosu <[email protected]> Co-authored-by: Alex Peters <[email protected]> * Test rust panic for regression (cherry picked from commit a52e604) * Fix client checksum verification (#1234) * Fix client checksum verification * Review comments (cherry picked from commit 1a8019b) # Conflicts: # x/wasm/client/cli/gov_tx.go * Fix merge conflict * Fix linters * Configure sonarcloud analysis (cherry picked from commit 85cf161) * Bump bufbuild/buf-setup-action from 1.15.0 to 1.15.1 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.15.0 to 1.15.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.15.0...v1.15.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit 730ea5a) * Make `CaptureIbcEvents` in ibctesting public. Before this change, it wasn't possible to implement the `chain.SendMsgs` method without [copying](https://github.com/public-awesome/ics721/blob/main/e2e/suite_helpers.go#L81-L98) them over. (cherry picked from commit b64fa07) * Upgrade to wasmvm 1.2.1 (backport #1245) (#1254) * Upgrade to wasmvm 1.2.1 (#1245) * Use wasmvm store adapter * Bump wasmvm to v1.2.1 (cherry picked from commit 850f901) # Conflicts: # go.mod # go.sum # x/wasm/keeper/keeper.go * Resolve conflicts --------- Co-authored-by: Alexander Peters <[email protected]> * WIP All cometbft (#1244) * Dep upgrade; use CometBft * Remove duplicte message events * Add changelog for v0.31.0 (#1188) * Start changelog for v0.31.0 * Add ICA upgrade * Add proto version link to buf.build * Update changelog (#1239) * Update changelog * Update changelog with latest changes * Set release date --------- Co-authored-by: pinosu <[email protected]> (cherry picked from commit bc0e817) * Remove new message type event * Support msg update params gov proposal (#1247) * Add MsgUpdateParams support * Implement UpdateParams msg * Fix test UpdateParams * Add migration test * Fix * Fix lint issues * Revert changes according to review feedback * Remove more x/params dependencies * Remove x/params from genesis test * Formatting * Restore old changes * fix lint * Fix tests and restructure migrations * Rename alias for convention --------- Co-authored-by: Alex Peters <[email protected]> * Fix test data generator (#1263) * linting 47 pr (#1261) * lint cosmwasm for sdk 47 * fix * remove setGenesis * remove additional unused functions * pass tests * use SDK's errors module * unecessary conversions * unnecessary conversions * remove unneeded event manager * complete linting of tests for 47 * add test for reimportation * check errors * Update x/wasm/keeper/proposal_integration_test.go Co-authored-by: Alexander Peters <[email protected]> * apply suggestion * suggestions * lints * don't return error in when making new transactions * no todo's in the code * Fix test data generator * Update x/wasm/types/genesis_test.go Co-authored-by: Alexander Peters <[email protected]> * use the full string invalid address (2 words) always --------- Co-authored-by: Alexander Peters <[email protected]> * Regenerate from proto; remove dead code; polish code * Set SDK version to v0.47x.0 (#1262) * Set SDK version to v0.47x.0 * Set chainID * Minor updates * Set chainID for simulations * Buf mod update * Use sdk tag instead of hash in buf * Bump ibc-go to v7.0.0 * faddat/re merge main (#1274) undefined --------- Co-authored-by: vuong <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: llllllluc <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Gjermund Garaba <[email protected]> Co-authored-by: Nikhil Suri <[email protected]> Co-authored-by: Paul <[email protected]> Co-authored-by: pinosu <[email protected]> Co-authored-by: ekez <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]>

faddat added 4 commits March 15, 2023 17:08

lint cosmwasm for sdk 47

ffe08cf

fix

fed39f0

remove setGenesis

2a3ab90

remove additional unused functions

96441ba

faddat added 6 commits March 15, 2023 18:02

pass tests

8eab6df

use SDK's errors module

607d974

unecessary conversions

a668c93

unnecessary conversions

b6f3067

remove unneeded event manager

02a931a

complete linting of tests for 47

28f360b

faddat mentioned this pull request Mar 15, 2023

Cosmos-SDK v0.47 integration brach #1149

Merged

faddat added 3 commits March 15, 2023 18:21

add test for reimportation

9445a53

Merge remote-tracking branch 'upstream/develop_sdk47' into linting-47-pr

51afb97

check errors

664582c

faddat marked this pull request as ready for review March 15, 2023 11:35

faddat requested a review from alpe as a code owner March 15, 2023 11:35

alpe reviewed Mar 15, 2023

View reviewed changes

faddat and others added 7 commits March 15, 2023 19:19

Update x/wasm/keeper/proposal_integration_test.go

8adafd7

Co-authored-by: Alexander Peters <[email protected]>

apply suggestion

81e485c

suggestions

064f25c

lints

609db7c

don't return error in when making new transactions

8204175

no todo's in the code

2048d5e

Fix test data generator

efccaa4

alpe mentioned this pull request Mar 15, 2023

Fix fuzzer setup #1263

Merged

faddat and others added 3 commits March 15, 2023 19:37

Update x/wasm/types/genesis_test.go

baaa5fe

Co-authored-by: Alexander Peters <[email protected]>

Merge remote-tracking branch 'upstream/fix_fuzzer_setup' into linting…

f35b218

…-47-pr

use the full string invalid address (2 words) always

e0d9f57

Merge remote-tracking branch 'upstream/develop_sdk47' into linting-47-pr

9c8678d

faddat mentioned this pull request Mar 15, 2023

sdk 47 working branch #1202

Closed

alpe approved these changes Mar 15, 2023

View reviewed changes

x/wasm/keeper/handler_plugin_encoders_test.go Outdated Show resolved Hide resolved

x/wasm/keeper/reflect_test.go Outdated Show resolved Hide resolved

alpe merged commit bb13192 into CosmWasm:develop_sdk47 Mar 15, 2023

alpe mentioned this pull request Mar 15, 2023

Minor chore #1265

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linting 47 pr #1261

linting 47 pr #1261

faddat commented Mar 15, 2023

alpe commented Mar 15, 2023

faddat commented Mar 15, 2023 •

edited

Loading

alpe left a comment

faddat commented Mar 15, 2023

codecov bot commented Mar 15, 2023 •

edited

Loading

alpe left a comment

linting 47 pr #1261

linting 47 pr #1261

Conversation

faddat commented Mar 15, 2023

alpe commented Mar 15, 2023

faddat commented Mar 15, 2023 • edited Loading

alpe left a comment

Choose a reason for hiding this comment

faddat commented Mar 15, 2023

codecov bot commented Mar 15, 2023 • edited Loading

Codecov Report

alpe left a comment

Choose a reason for hiding this comment

faddat commented Mar 15, 2023 •

edited

Loading

codecov bot commented Mar 15, 2023 •

edited

Loading