Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure history position does not conflict #1462

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Ensure history position does not conflict #1462

merged 1 commit into from
Jun 29, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jun 27, 2023

Add extra safety net to ensure no overlap in a mixed environment with 20 + 32 byte contract addresses break the position counter
For a single contract not 2 addresses exists, so this not really an issue

@alpe alpe requested a review from pinosu June 27, 2023 16:30
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit c376c93 into main Jun 29, 2023
@alpe alpe deleted the history_position branch June 29, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants