Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main to 50 #1544

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 4, 2023

  • better and more minimal update to latest ibc
  • golangci-lint run ./... --fix

faddat and others added 6 commits July 24, 2023 15:16
* use a constant

* use a constant for badAddress
* Update CHANGELOG

* Fix comments

* Set date
* golangci-lint run ./... --fix

* linting completed

* use the CosmWasm repo as part of the gci config
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.25.0 to 1.25.1.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.25.0...v1.25.1)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@faddat faddat requested a review from alpe as a code owner August 4, 2023 03:54
@faddat faddat changed the title linter autofixes for v50 for ease of merge with main merge main to 50 Aug 4, 2023
@faddat
Copy link
Contributor Author

faddat commented Aug 4, 2023

note to self: root command needs to be refactored

@faddat
Copy link
Contributor Author

faddat commented Aug 23, 2023

@hoangdv2429 it looks like it is different in ci.

@hoangdv2429
Copy link

So there is a test call TestRecursiveSmartQuery, as we can see in the test. There is one case that trigger ErrQueryInvalid and the outOfGas is expected to be false. So I guess we can working on that direction, comparing the gas consumption between running it on CI and on local, investigate more on that.

webmaster128 and others added 4 commits August 24, 2023 10:55
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.5.3...v3.6.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@hoangdv2429 hoangdv2429 force-pushed the ease-of-merge-linter-autofixes branch from 5dd3211 to 1028512 Compare August 25, 2023 16:14
@faddat
Copy link
Contributor Author

faddat commented Aug 25, 2023

nice work @hoangdv2429 !

@alpe
Copy link
Contributor

alpe commented Sep 19, 2023

Thanks again for all the work. 💪
Closing this in favour of #1611

@alpe alpe closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants