Start rework channel query #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1620 +/- ##
==========================================
+ Coverage 56.59% 56.65% +0.06%
==========================================
Files 64 64
Lines 8755 8758 +3
==========================================
+ Hits 4955 4962 +7
+ Misses 3414 3411 -3
+ Partials 386 385 -1
|
pinosu
reviewed
Sep 13, 2023
| assert: func(t *testing.T, d []byte) { | ||
| rsp := unmarshalReflect[wasmvmtypes.ListChannelsResponse](t, d) | ||
| assert.Nil(t, rsp.Channels) | ||
| }, |
pinosu
reviewed
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1597
This may change the result set for
list-channelqueries when no port is passed.Before we returned all open channels but now we fallback to the contracts ibc port or return an empty list for non ibc-contracts.