Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SDK v0.50.1 #1696

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Upgrade to SDK v0.50.1 #1696

merged 5 commits into from
Nov 13, 2023

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Nov 7, 2023

No description provided.

@pinosu pinosu requested a review from alpe as a code owner November 7, 2023 20:55
@pinosu pinosu changed the title Upgrade to SDK v0.50.1 [WIP] Upgrade to SDK v0.50.1 Nov 7, 2023
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see the final release.
CI fails currently with app.go: https://app.circleci.com/pipelines/github/CosmWasm/wasmd/4365/workflows/d51653e8-0ef0-46bc-81f9-aa6be082d6ba/jobs/20254

Can you also 👀 at the changes in #1681 , please

@alpe alpe mentioned this pull request Nov 8, 2023
go.mod Outdated
cosmossdk.io/math v1.1.3-rc.1
cosmossdk.io/store v1.0.0-rc.0
cosmossdk.io/math v1.2.0
cosmossdk.io/store v1.0.0
cosmossdk.io/tools/confix v0.0.0-20230818115413-c402c51a1508

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, we have as well tagged these: cosmos/cosmos-sdk#18410

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1696 (9ea7578) into main (62d91d9) will increase coverage by 0.62%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1696      +/-   ##
==========================================
+ Coverage   56.80%   57.42%   +0.62%     
==========================================
  Files          62       62              
  Lines        8232     8143      -89     
==========================================
  Hits         4676     4676              
+ Misses       3119     3030      -89     
  Partials      437      437              
Files Coverage Δ
app/app.go 84.37% <100.00%> (ø)
x/wasm/types/tx.go 67.11% <ø> (+15.55%) ⬆️

@pinosu pinosu changed the title [WIP] Upgrade to SDK v0.50.1 Upgrade to SDK v0.50.1 Nov 13, 2023
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! Thanks for the upgrade!

@alpe alpe merged commit 4313d7f into main Nov 13, 2023
16 checks passed
@pinosu pinosu deleted the upgrade_sdk_50 branch November 13, 2023 11:38
@pinosu pinosu mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants