Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sdk to launchpad #209

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Upgrade sdk to launchpad #209

merged 2 commits into from
Jul 21, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jul 20, 2020

After #208
See #191

Upgrade to cosmos-sdk v0.39.0


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   72.08%   72.08%           
=======================================
  Files          27       27           
  Lines        2629     2629           
=======================================
  Hits         1895     1895           
+ Misses        622      621    -1     
- Partials      112      113    +1     
Impacted Files Coverage Δ
app/app.go 89.34% <100.00%> (ø)
lcd_test/helpers.go 75.71% <100.00%> (+0.71%) ⬆️
x/wasm/internal/keeper/keeper.go 91.10% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1aa2f5...0a045ce. Read the comment docs.

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as soon as the final release is cut.

One thing I noticed is the painful duplication of wasmd and wasmgovd code. I will make a new issue on that

Base automatically changed from history_store_196 to master July 21, 2020 07:09
@alpe alpe changed the title Upgrade sdk to launchpad rc0 Upgrade sdk to launchpad Jul 21, 2020
@alpe alpe marked this pull request as ready for review July 21, 2020 07:49
@ethanfrey
Copy link
Member

Looking good 🚀

Time to merge. And then a v0.10.0-alpha tag. I think we are feature complete for 0.10 except for updating CosmWasm and some minor improvements

@alpe alpe merged commit 6e021d9 into master Jul 21, 2020
@alpe alpe deleted the upgrade_to_launchpad branch July 21, 2020 12:11
@ethanfrey ethanfrey mentioned this pull request Jul 24, 2020
4 tasks
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants