Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set bech32 prefix #316

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Set bech32 prefix #316

merged 1 commit into from
Nov 17, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 17, 2020

Resolves #313

  • Default "wasm" in app
  • Set prefix in build (not really needed with app default but consistent with building other artifacts)

No covered are cosmos prefixes in unit tests

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #316 (6045693) into master (06cd063) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   17.53%   17.53%           
=======================================
  Files          35       35           
  Lines       10519    10519           
=======================================
  Hits         1844     1844           
  Misses       8572     8572           
  Partials      103      103           
Impacted Files Coverage Δ
app/app.go 88.38% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06cd063...6045693. Read the comment docs.

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@alpe alpe merged commit 807956b into master Nov 17, 2020
@alpe alpe deleted the bech32_prefix_313 branch November 17, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change bech32 prefix for wasmd
2 participants