Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sdk new wasm #656

Closed
wants to merge 32 commits into from
Closed

New sdk new wasm #656

wants to merge 32 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Oct 19, 2021

Hi!

I had to make a few judgement calls when producing this, but pretty sure that I made the correct ones.

I kept cosmwasm/wasmd's gas settings at all times, and brought in provenance's changes that account for the lack of sdk.addrlen

I also included some of their comments, some of em were interesting

wdyt?

channa-figure and others added 30 commits August 4, 2021 11:25
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. But since you and provenance seem to be the ones interested in 0.44 support, I would suggest you collaborate with them on this PR, maybe in their fork?

We will look at this after wasmd hits 1.0.0-beta (awaiting audits). We also have a lot of pending work for tgrade, which is higher priority and reviewing this upgrade will take some time.

If you and provenance co-review some PR and both agree, it will likely be much easier to get it in. If there are some elements that can fit in without the Cosmos SDK bump, we are happy for smaller PRs now (I know @fkneeland-figure has been doing some cleanup PRs with format and linting and such, so that a future 0.44 PR will have a smaller diff)


require (
github.com/CosmWasm/wasmvm v1.0.0-beta
github.com/cosmos/cosmos-sdk v0.42.10
github.com/cosmos/cosmos-sdk v0.44.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not even looking at PRs to bump past 0.42 until we cut a 1.0 of wasmd.
We are currently at 0.20, which is compatible with cosmwasm 1.0-beta, but missing a few last items to fine tune.
We are also waiting until the cosmos hub adopts some version of Cosmos SDK to add support for it in wasmd... this may be soon for 0.44.x????

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha :).

So to get mildly opinionated here, v0.44.* is worth it.

It fixes the number of usability issues and allows for the use of the go-ibc module.

Also the whole PR..... well, per our conversation, I kept your changes to anything gas related, and then I kept their changes to stuff that I knew had changed due to 0.44.2.

I've PR'd this to them too, and I'm curious to hear what they say :).

Thanks for all your work on cw, I think it's a gem.

@faddat
Copy link
Contributor Author

faddat commented Oct 20, 2021

Please close this if you'd prefer not to merge /review /etc it.

<3

@alpe
Copy link
Contributor

alpe commented Oct 21, 2021

@faddat Thanks a lot for your contribution! 💐
As Ethan pointed out the timing and our priorities are a bit different on our side so that I would close this PR now to not create confusion.
For reference I point to your PR on the provenance fork: provenance-io#2

@alpe alpe closed this Oct 21, 2021
@faddat
Copy link
Contributor Author

faddat commented Nov 23, 2021

@sunnya97 This one works.....

BUT it doesn't have ibc-go 2.0 and it's not up to date with master.

I am currently working on:
https://github.com/notional-labs/wasmd/tree/ibc-go-migration

But please note that it is kind of a cheat; what it is:

  • Master of this repo's wasmd
  • 0.44.3
  • ibc-go v1.2.3

With the hope of upgrading before Moneta is released.

I will make a draft PR of my work on the "ibc-go-migration" branch, which is intended to be as faithful to the original CosmWasm design as possible-- basically instead of using Provenance (except that some of the test code is taken from theirs) I used this document:

https://github.com/cosmos/ibc-go/blob/main/docs/migrations/ibc-migration-043.md

I'm now in the cleanup stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants