You must explicitly declare --no-admin on cli instantiate if that is what you want #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
approved these changes
Jan 21, 2022
| flagSet.Set("label", "testing") | ||
| flagSet.Set("run-as", myWellFundedAccount) | ||
| flagSet.Set("no-admin", "true") | ||
| flagSet.Set("admin", myWellFundedAccount) |
ethanfrey
force-pushed
the
719-explicitly-no-admin
branch
from
a44184a
to
53ff515
Compare
|
Rebased and updated changelog. Should be good to merge |
Merged
ethanfrey
force-pushed
the
719-explicitly-no-admin
branch
from
53ff515
to
1e78fbc
Compare
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
+ Coverage 59.93% 59.95% +0.01%
==========================================
Files 49 49
Lines 5604 5613 +9
==========================================
+ Hits 3359 3365 +6
- Misses 2002 2004 +2
- Partials 243 244 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #719