Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/make compact callback async #68

Merged
merged 9 commits into from
Aug 1, 2023
Merged

Fix/make compact callback async #68

merged 9 commits into from
Aug 1, 2023

Conversation

tbrezot
Copy link
Contributor

@tbrezot tbrezot commented Jul 21, 2023 

fix: make compact callbacks async

- `update_lines`
- `list_removed_locations`
- `filter_removed_locations`

Fix doc mistake for `list_removed_locations` (negation was missing)

bgrieder
bgrieder previously approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@bgrieder bgrieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Should we remove the #[cfg(feature = "live_compact")] methods right now ?

@tbrezot
Copy link
Contributor Author

tbrezot commented Jul 27, 2023

LGTM Should we remove the #[cfg(feature = "live_compact")] methods right now ?

Done in 7049a3e

@Cosmian Cosmian deleted a comment from sonatype-lift bot Jul 27, 2023
tbrezot
tbrezot commented Jul 31, 2023
View reviewed changes
Copy link
Contributor Author

@tbrezot tbrezot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to track this commit using a dedicated branch to allow merging fix/make compact callback async into develop?

french_dataset.json Outdated Show resolved Hide resolved
src/upsert.rs Outdated Show resolved Hide resolved
.DS_Store Outdated Show resolved Hide resolved
src/upsert.rs Outdated Show resolved Hide resolved
src/upsert.rs Outdated Show resolved Hide resolved
src/upsert.rs Outdated Show resolved Hide resolved
src/upsert.rs Outdated Show resolved Hide resolved
src/upsert.rs Outdated Show resolved Hide resolved
@tbrezot tbrezot force-pushed the fix/make_compact_callback_async branch from 34d3ada to 367439b Compare August 1, 2023 09:15
@tbrezot tbrezot merged commit bdff0bb into develop Aug 1, 2023
10 checks passed
@tbrezot tbrezot deleted the fix/make_compact_callback_async branch August 1, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrieder bgrieder bgrieder left review comments

@ackRow ackRow ackRow approved these changes

@Manuthor Manuthor Awaiting requested review from Manuthor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tbrezot @bgrieder @ackRow @Manuthor