Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/edit policy #63

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Feat/edit policy #63

merged 3 commits into from
Nov 10, 2023

Conversation

ackRow
Copy link

@ackRow ackRow commented Oct 10, 2023

No description provided.

@ackRow ackRow force-pushed the feat/edit_policy branch 5 times, most recently from e81a6df to 16c8604 Compare October 18, 2023 12:20
@ackRow ackRow force-pushed the feat/edit_policy branch 2 times, most recently from 79d6faa to b3e4fdd Compare October 20, 2023 07:27
tbrezot
tbrezot reviewed Oct 20, 2023
View reviewed changes
crate/cli/src/actions/cover_crypt/policy.rs Outdated Show resolved Hide resolved
crate/cli/src/actions/cover_crypt/policy.rs Outdated Show resolved Hide resolved
crate/cli/src/actions/cover_crypt/policy.rs Outdated Show resolved Hide resolved
crate/kmip/src/kmip/kmip_operations.rs Outdated Show resolved Hide resolved
crate/kmip/src/kmip/kmip_operations.rs Outdated Show resolved Hide resolved
crate/kmip/src/kmip/kmip_operations.rs Outdated Show resolved Hide resolved
crate/kmip/src/kmip/kmip_operations.rs Outdated Show resolved Hide resolved
crate/pyo3/src/py_kms_client.rs Outdated Show resolved Hide resolved
crate/pyo3/src/py_kms_client.rs Show resolved Hide resolved
crate/pyo3/src/py_kms_client.rs Outdated Show resolved Hide resolved
tbrezot
tbrezot reviewed Oct 23, 2023
View reviewed changes
crate/pyo3/src/py_kms_client.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
tbrezot
tbrezot reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@tbrezot tbrezot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go :)

crate/pyo3/src/py_kms_client.rs Show resolved Hide resolved
crate/pyo3/src/py_kms_client.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Outdated Show resolved Hide resolved
crate/server/src/core/cover_crypt/update_policy.rs Show resolved Hide resolved
crate/utils/src/crypto/cover_crypt/attributes.rs Show resolved Hide resolved
@ackRow ackRow mentioned this pull request Nov 2, 2023
Open
@Manuthor Manuthor force-pushed the feat/edit_policy branch 2 times, most recently from 0b44d97 to 7e08a81 Compare November 10, 2023 08:40
@Manuthor Manuthor merged commit cc369c9 into develop Nov 10, 2023
34 checks passed
@Manuthor Manuthor deleted the feat/edit_policy branch November 10, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrezot tbrezot tbrezot left review comments

@Manuthor Manuthor Awaiting requested review from Manuthor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ackRow @tbrezot @Manuthor