Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse2D headers install path #7

Closed
EiffL opened this issue Nov 27, 2017 · 0 comments
Closed

Sparse2D headers install path #7

EiffL opened this issue Nov 27, 2017 · 0 comments
Assignees

Comments

@EiffL
Copy link
Member

EiffL commented Nov 27, 2017

@sfarrens I notice that the install path for headers is:

INSTALL(FILES ${inc_lib} DESTINATION include)

I would suggest using a subdirectory, like:

INSTALL(FILES ${inc_lib} DESTINATION include/sparse2d)

This prevents a lot of annoying name confusions in includes by keeping the library clearly isolated.
Then in codes that use that library, one can import things as:

#include <sparse2d/IM_IO.h>

Also, one other thing, the headers for the tools are not installed.

I'm openning a branch to fix these problem and will open a pull request

@EiffL EiffL self-assigned this Nov 27, 2017
sfarrens added a commit that referenced this issue Oct 17, 2022
* updated to v3 of Catch2

* updated CI with Catch2

* change permissions for Ubuntu Catch2 installation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants