Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalise CMAKE_CXX_FLAGS #29

Closed
wants to merge 1 commit into from
Closed

Rationalise CMAKE_CXX_FLAGS #29

wants to merge 1 commit into from

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Jul 18, 2019 •
edited
Loading

The if looks useless, as it was setting exactly the same things in both branches, the only difference being FFTW_FLAGS which I guess was a typo?

With this PR I use CMAKE_CXX_FLAGS to set the flags common to all build types, and CMAKE_CXX_FLAGS_RELEASE and CMAKE_CXX_FLAGS_DEBUG for the build-type-specific flags.

@sfarrens sfarrens mentioned this pull request Aug 24, 2020
Merged
@sfarrens
Copy link
Member

Apologies for the delay. Your suggestions were implemented in #33.

@sfarrens sfarrens closed this Sep 14, 2020
@giordano giordano deleted the rationalise-cmake-flags branch September 14, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giordano @sfarrens