Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated build for PySAP #43

Merged
merged 6 commits into from
Jan 18, 2023
Merged

Updated build for PySAP #43

merged 6 commits into from
Jan 18, 2023

Conversation

sfarrens
Copy link
Member

@sfarrens sfarrens commented Dec 13, 2022 •
edited
Loading

  • Added option to install Python binding to custom location (required for PySAP)
  • Updated the Pybind11 options in CMake
  • Extended scope of external package variables
  • Added optional library dependency for external package build
  • Added CI job for testing PySAP compatible build
  • Cleaned up find_pkg funciton

@sfarrens sfarrens self-assigned this Dec 13, 2022
@sfarrens sfarrens marked this pull request as draft December 13, 2022 15:08
@sfarrens sfarrens marked this pull request as ready for review December 13, 2022 17:38
@sfarrens
Copy link
Member Author

@jstarck please check this and approve if you agree with the changes proposed

@sfarrens sfarrens merged commit 9307af1 into master Jan 18, 2023
@sfarrens sfarrens deleted the pysap_build branch January 18, 2023 17:05
@sfarrens sfarrens mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstarck jstarck Awaiting requested review from jstarck

Assignees

@sfarrens sfarrens

Labels
clean up enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfarrens