Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_io handles sextractor header #670

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

lbaumo
Copy link

@lbaumo lbaumo commented Dec 12, 2023

Summary

This allows get_header in file_io to convert the fits_ldac header, stored as a binary table, from sextractor to a dictionary. It also corrects the documentation for get_header. This is the first step in addressing #632 as well as #616 and #604.

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@lbaumo lbaumo added documentation Improvements or additions to documentation clean up labels Dec 12, 2023
@lbaumo lbaumo self-assigned this Dec 12, 2023
Copy link
Contributor

@martinkilbinger martinkilbinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe you can run black on the modified files for automatic formatting.

@lbaumo
Copy link
Author

lbaumo commented Dec 13, 2023

what is going on with the CI tests? It looks like installation is failing.

@martinkilbinger
Copy link
Contributor

what is going on with the CI tests? It looks like installation is failing.

Looks like a version conflict between numba and numpy. I had to upgrade numpy to a newer version due to some conda errors. Try to set numba=0.58.1.

There might be other CI errors, this has not been working for quite some time.

@lbaumo lbaumo added this to the ShapePipe v1.1.0 Release milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up documentation Improvements or additions to documentation
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

2 participants