Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Achievement condition validations #425

Merged
merged 9 commits into from
Jul 29, 2015
Merged

Achievement condition validations #425

merged 9 commits into from
Jul 29, 2015

Commits on Jul 29, 2015

  1. Fixed bugs with achievement page 

    Added missing table headers
Published status was shown regardless of ability to manage achievements
    @dariusf
    dariusf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    da4454b View commit details
    Browse the repository at this point in the history

  2. Added title method to conditions 

    For use in polymorphic contexts where all require is the
human-readable anme of the condition
    @dariusf
    dariusf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    ffe952b View commit details
    Browse the repository at this point in the history

  3. Displayed achievement requirements in index

    @dariusf
    dariusf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    acd24a7 View commit details
    Browse the repository at this point in the history

  4. Added validations for achievement conditions 

    This ensures that there cannot be duplicate or self-referential
achievement conditions
    @dariusf
    dariusf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    05dbfd2 View commit details
    Browse the repository at this point in the history

  5. Added matcher for content tags

    @dariusf
    dariusf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    06fdcce View commit details
    Browse the repository at this point in the history

  6. Added specs for validations and cleaned up old specs

    @dariusf
    dariusf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    28989ed View commit details
    Browse the repository at this point in the history

  7. Added non-null constraints to condition fields 

    Conditions must be associated with a conditional.
Achievement conditions must be associated with an achievement.
    @dariusf
    dariusf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    3046664 View commit details
    Browse the repository at this point in the history

  8. Removed course_condition factory 

    It fails FactoryGirl linting because it doesn't declare the now non-null
`conditional` association. Since it cannot be directly instantiated, and
the factories for things which act_as conditions do declare
`conditional`, it isn't needed.
    @dariusf
    dariusf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    e6a0f0d View commit details
    Browse the repository at this point in the history

  9. Restructured activerecord translations

    @dariusf
    dariusf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    61e751d View commit details
    Browse the repository at this point in the history