Fix Source Course only to Current Course during Duplication #7481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bivanalhar
force-pushed
the
bivan/fix-source-course-duplication
branch
2 times, most recently
from
953dabb
to
27b1e5b
Compare
bivanalhar
force-pushed
the
bivan/fix-source-course-duplication
branch
2 times, most recently
from
c69b03d
to
0cdacfe
Compare
cysjonathan
requested changes
Aug 7, 2024
client/app/bundles/course/duplication/pages/Duplication/index.jsx
Outdated
Show resolved
Hide resolved
client/app/bundles/course/duplication/pages/Duplication/index.jsx
Outdated
Show resolved
Hide resolved
bivanalhar
force-pushed
the
bivan/fix-source-course-duplication
branch
from
0cdacfe
to
8c9f8cd
Compare
bivanalhar
force-pushed
the
bivan/fix-source-course-duplication
branch
3 times, most recently
from
911d219
to
b113b04
Compare
cysjonathan
force-pushed
the
bivan/fix-source-course-duplication
branch
from
b113b04
to
5b1f455
Compare
- only allow duplication from current course - remove all APIs used only in choosing source course - change page title in duplication page to include course title - remove unnecessary translation - add en/zh translations for Destination Instance and Duplicate Data
- due to change in the UI for duplication page - source course button needs to be removed
cysjonathan
force-pushed
the
bivan/fix-source-course-duplication
branch
from
5b1f455
to
398f7bc
Compare
cysjonathan
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #7289
Approach
From the Possible Fixes enlisted in the Issue page, we decided to go with the first one, which is only to lock the source course option to the current course. The rationale behind is that since this Duplicate Data is available for all courses, then if user wishes to duplicate something from other course, he/she needs to navigate to that course first then can do the duplication properly
UI Improvement
Since we only restrict the option of Source Course into the current course, there is a slight change in the UI for Duplicate Data page, in which the options for Source Course is removed altogether and the Title of the page includes the Course Title. The comparison is as follows: