Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster to KW check in client constructor #421

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add cluster to KW check in client constructor #421

merged 2 commits into from
Oct 26, 2023

Conversation

billschereriii
Copy link
Contributor

This lets a call like c = Client(cluster=False) work as expected

@billschereriii billschereriii added the area: python Issues related to the Python Client label Oct 26, 2023
@billschereriii billschereriii self-assigned this Oct 26, 2023
MattToast
MattToast approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix!!

@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #421 (5d28b50) into develop (0467d8a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #421      +/-   ##
===========================================
- Coverage    78.80%   78.79%   -0.01%     
===========================================
  Files           97       97              
  Lines         7364     7362       -2     
===========================================
- Hits          5803     5801       -2     
  Misses        1561     1561
Files Coverage Δ
src/cpp/client.cpp 88.98% <ø> (-0.02%) ⬇️
src/python/module/smartredis/client.py 97.09% <100.00%> (ø)

@MattToast MattToast mentioned this pull request Oct 26, 2023
Merged
@billschereriii billschereriii merged commit 4b6c9cd into CrayLabs:develop Oct 26, 2023
46 checks passed
@billschereriii billschereriii deleted the morector branch October 26, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattToast MattToast MattToast approved these changes

Assignees

@billschereriii billschereriii

Labels
area: python Issues related to the Python Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billschereriii @MattToast