Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve linting issue #444

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

billschereriii
Copy link
Contributor

Avoid wildcard import by reformatting import. Avoid apparent non-use of errors module by restricting search of pybind error name to errors module.

@billschereriii billschereriii added the area: python Issues related to the Python Client label Dec 19, 2023
@billschereriii billschereriii self-assigned this Dec 19, 2023
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last small ask, but nothing worth holding up approval over. Otherwise LGTM!!

src/python/module/smartredis/util.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #444 (7dff218) into develop (f5e8d15) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #444   +/-   ##
========================================
  Coverage    78.83%   78.83%           
========================================
  Files           97       97           
  Lines         7366     7366           
========================================
  Hits          5807     5807           
  Misses        1559     1559           
Files Coverage Δ
src/python/module/smartredis/util.py 93.10% <100.00%> (ø)

@billschereriii billschereriii merged commit 7d56af7 into CrayLabs:develop Dec 19, 2023
46 checks passed
@billschereriii billschereriii deleted the linty branch December 19, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: python Issues related to the Python Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants