Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ubuntu to version 22.04 and gcc to version 11 #484

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

AlyssaCote
Copy link
Contributor

@AlyssaCote AlyssaCote commented Apr 18, 2024

After dropping python 3.8, there's been some issues with ubuntu versions and gcc version for the smartsim dev docs. Upgrading ubuntu to 22.04 is necessary now that we've dropped support for python 3.8 and should solve the problem.

@AlyssaCote AlyssaCote marked this pull request as draft April 18, 2024 23:25
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (8d32cbf) to head (5673b92).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #484       +/-   ##
============================================
+ Coverage    78.84%   95.92%   +17.08%     
============================================
  Files           97       10       -87     
  Lines         7369      884     -6485     
============================================
- Hits          5810      848     -4962     
+ Misses        1559       36     -1523     

see 87 files with indirect coverage changes

@AlyssaCote AlyssaCote marked this pull request as ready for review April 19, 2024 00:11
@AlyssaCote AlyssaCote requested a review from ashao April 19, 2024 00:12
Copy link
Member

@ashao ashao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the gcc version!

@AlyssaCote AlyssaCote merged commit 856945d into CrayLabs:develop Apr 19, 2024
30 checks passed
@amandarichardsonn amandarichardsonn added the area: build Issues related to builds, makefiles, installs, etc label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Issues related to builds, makefiles, installs, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants