Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build wheel #491

Merged
merged 2 commits into from
May 14, 2024
Merged

Fix build wheel #491

merged 2 commits into from
May 14, 2024

Conversation

mellis13
Copy link
Collaborator

Compiler errors have shown up in the build wheel for SmartRedis. This PR aims to fix those compiler errors.

@mellis13 mellis13 added area: build Issues related to builds, makefiles, installs, etc area: C++ Issues related to the C++ client labels May 14, 2024
@mellis13 mellis13 requested a review from ankona May 14, 2024 01:01
@mellis13 mellis13 marked this pull request as ready for review May 14, 2024 04:40
ankona
ankona approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@ankona ankona merged commit c9329cd into CrayLabs:develop May 14, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankona ankona ankona approved these changes

Assignees
No one assigned
Labels
area: build Issues related to builds, makefiles, installs, etc area: C++ Issues related to the C++ client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mellis13 @ankona