-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build dependencies as external projects #497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashao
force-pushed
the
cmake_external_project
branch
3 times, most recently
from
June 21, 2024 20:31
eaa2773
to
0cbcebf
Compare
ashao
force-pushed
the
cmake_external_project
branch
3 times, most recently
from
June 27, 2024 23:31
8adce98
to
e3e6885
Compare
ashao
force-pushed
the
cmake_external_project
branch
from
July 2, 2024 17:20
22b4b43
to
854199d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #497 +/- ##
============================================
- Coverage 95.92% 78.24% -17.69%
============================================
Files 10 90 +80
Lines 884 6867 +5983
============================================
+ Hits 848 5373 +4525
- Misses 36 1494 +1458 |
mellis13
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making SmartSim compatible as an external project!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using a Makefile to download and install third-party dependencies for the library compilation (hiredis, redis++, and PyBind). This PR migrates this functionality to the
CMakeLists.txt
by adding hiredis and redis++ asExternalProject
s and by using cmake to download the pybind headers.