Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build dependencies as external projects #497

Merged
merged 25 commits into from
Jul 18, 2024

Conversation

ashao
Copy link
Member

@ashao ashao commented Jun 17, 2024

Previously we were using a Makefile to download and install third-party dependencies for the library compilation (hiredis, redis++, and PyBind). This PR migrates this functionality to the CMakeLists.txt by adding hiredis and redis++ as ExternalProjects and by using cmake to download the pybind headers.

@ashao ashao force-pushed the cmake_external_project branch 3 times, most recently from eaa2773 to 0cbcebf Compare June 21, 2024 20:31
@ashao ashao force-pushed the cmake_external_project branch 3 times, most recently from 8adce98 to e3e6885 Compare June 27, 2024 23:31
@ashao ashao requested a review from mellis13 July 2, 2024 17:27
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.24%. Comparing base (8613627) to head (72b4d71).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #497       +/-   ##
============================================
- Coverage    95.92%   78.24%   -17.69%     
============================================
  Files           10       90       +80     
  Lines          884     6867     +5983     
============================================
+ Hits           848     5373     +4525     
- Misses          36     1494     +1458     

see 80 files with indirect coverage changes

Copy link
Collaborator

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making SmartSim compatible as an external project!

@ashao ashao merged commit 4937fbd into CrayLabs:develop Jul 18, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants