Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake ExternalProject instructions #503

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

ashao
Copy link
Member

@ashao ashao commented Aug 8, 2024

Fixes some typos present in the documentation that describe how to include SmartRedis as a CMake ExternalProject.

@ashao ashao requested a review from ankona August 8, 2024 17:51
Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.07%. Comparing base (4937fbd) to head (016e9df).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #503       +/-   ##
============================================
- Coverage    95.92%   57.07%   -38.86%     
============================================
  Files           10      147      +137     
  Lines          884    11248    +10364     
  Branches         0     1120     +1120     
============================================
+ Hits           848     6420     +5572     
- Misses          36     4677     +4641     
- Partials         0      151      +151     

see 137 files with indirect coverage changes

@ashao ashao merged commit cd42026 into CrayLabs:develop Sep 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants