Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework RedisAI build to allow for GCC-14 testing #518

Merged
merged 13 commits into from
Oct 21, 2024
Merged

Conversation

ashao
Copy link
Member

@ashao ashao commented Oct 18, 2024

No description provided.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.62%. Comparing base (4937fbd) to head (3372fb1).
Report is 14 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #518       +/-   ##
============================================
- Coverage    95.92%   57.62%   -38.31%     
============================================
  Files           10      147      +137     
  Lines          884    11708    +10824     
  Branches         0     1127     +1127     
============================================
+ Hits           848     6747     +5899     
- Misses          36     4810     +4774     
- Partials         0      151      +151     

see 137 files with indirect coverage changes

@ashao ashao force-pushed the gcc-14 branch 3 times, most recently from 6a120d3 to 73c9f52 Compare October 21, 2024 19:59
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Comment on lines -87 to +90
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# Setup python within the container
- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
Copy link
Member

@MattToast MattToast Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping these up to date by the way!

@ashao ashao merged commit bebcd9c into CrayLabs:develop Oct 21, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants