Move compat recipies to datagen #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placeFluidSourceBlocks ->
fluidFillingPlaceFluidSourceBlocks
pipesPlaceFluidSourceBlocks
Attack8
force-pushed
the
mc1.18/compatdatagen
branch
from
d5bdd36
to
51f6c78
Compare
…8/compatdatagen # Conflicts: # src/generated/resources/.cache/cache # src/main/java/com/simibubi/create/foundation/data/recipe/CuttingRecipeGen.java
Closed
IThundxr
added
area: compatibility
zelophed
reviewed
Mar 16, 2024
src/main/java/com/simibubi/create/foundation/data/recipe/Mods.java
Outdated
Show resolved
Hide resolved
Remove duplicate enum entry
Reflect Mods.java update
Reflect Mods.java changes
Reflect Mods.java changes
Reflect Mods.java changes
|
Ok, ready for another review |
|
You renamed all your references to |
|
No, they are all supposed to be Mods.ATM. That should be fixed now |
|
Looks good. Appreciate your effort! |
|
Thanks! |
sarim
added a commit
to sarim/Create
that referenced
this pull request
May 9, 2024
This reverts commit f551107.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recipies in main/resources/data/create/recipies/compat to the compat folders of their respective recipe type
Edit: Also adds/updates compat for the following mods:
IC2 (Closes #5002)
Galosphere
Oreganized (Closes #5103)
Hex Casting (Closes #4358)
The Vault
Nether's Exoticism