Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New" Supabase auth ssr package #29

Closed
CharlBest opened this issue Mar 11, 2024 · 5 comments
Closed

"New" Supabase auth ssr package #29

CharlBest opened this issue Mar 11, 2024 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@CharlBest
Copy link
Contributor

Amazing project! Exactly what I was looking for.

Curious what are your thoughts on the @supabase/ssr package rather than using auth-helpers?
It seems going forward that it is the package that will get the updates and be maintained. That said, I'm not sure if there are differences now so wouldn't have an influence at this stage, right?

image

Saw a YouTuber do the migration, if you are interested.

@scosman
Copy link
Contributor

scosman commented Mar 11, 2024

I looked at this, but honestly I can't remember why I didn't migrate. I'd want to keep the CSR option because svelte does such a good job of it. Would be curious if SSR can run in CSR for sveltekit.

P2 nice to have. No bug per se, but keeping up with times always good.

We've had issues with auth-helpers: 9211be0

@owenversteeg
Copy link
Contributor

I think it'd be good to migrate, as Supabase seems to be phasing out the auth-helpers stuff pretty aggressively and providing less support and attention there. Maybe something to add to your todo list from your other issue @CharlBest? :)

@scosman scosman added enhancement New feature or request help wanted Extra attention is needed labels Mar 12, 2024
@CharlBest
Copy link
Contributor Author

CharlBest commented Mar 13, 2024

@scosman @owenversteeg
I saw this repo using the SSR package. Looks like it can be a good starting point.
https://github.com/psegarel/supabase_auth-sveltekit4

Side note: I also like how they encapsulate the SVG icons to declutter main components

@kizivat
Copy link
Contributor

kizivat commented May 9, 2024

I just migrated in my fork but I still get some supabase warnings about using user object from the unsafe getSession() which I cannot pin-point where they are occurring exactly.

@scosman
Copy link
Contributor

scosman commented Aug 30, 2024

Finallllly done: #135

@scosman scosman closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants