Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking Sign Up sends multiple emails #30

Closed
CharlBest opened this issue Mar 11, 2024 · 6 comments
Closed

Clicking Sign Up sends multiple emails #30

CharlBest opened this issue Mar 11, 2024 · 6 comments

Comments

@CharlBest
Copy link
Contributor

Clicking the sign up button will send multiple requests/emails. This is probably the case for "forgot password" as well.

image

Possible solutions:

  • disable the button after you click it with a 1 minute re-activation
  • indefinitely disable button (until refresh)
  • button is still clickable but in the background, debounce and don't send another request within x seconds
@scosman
Copy link
Contributor

scosman commented Mar 11, 2024

Can you add repo steps? I'm only getting 1 email.

@CharlBest
Copy link
Contributor Author

  1. I deleted my account
  2. Went to https://saasstarter.work/login/sign_up/
  3. Typed in my email and password
  4. Click on SIGN UP, wait +- 3 seconds
  5. Click on SIGN UP 3 more times with 1 second intervals
image image

Browser: Chrome

@scosman
Copy link
Contributor

scosman commented Mar 11, 2024

Ah, it re-enables after it's complete!

is this not a bug in supabase/auth-helpers? They handle all this UI.

@CharlBest
Copy link
Contributor Author

CharlBest commented Mar 11, 2024

I haven't looked into the auth-ui library so much, just assumed it would have events you can hook into and do things accordingly like show a different UI while it's loading but doesn't seem like that is the case.

Saw it went into Maintenance Mode about a month ago. That's very sad 😭 Rather than maintaining framework-specific packages, they should just have a standard/native html/js package.

image

@owenversteeg
Copy link
Contributor

Hmm, not sure this should be closed, the issue still exists even if auth-ui is in "maintenance mode". I suppose this is another reason to migrate to SSR from auth-helpers?

@CharlBest CharlBest reopened this Mar 12, 2024
@scosman
Copy link
Contributor

scosman commented Mar 13, 2024

Duplicate of #29

Back and forth on this one 🤣. But we don’t need 2 issues for same action item. If the upgrade to ssr is the fix, let’s track that in 29. If it’s not let’s file a bug on supabase because it’s on their side.

@scosman scosman closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants